Replace scoped_ptr with unique_ptr in webrtc/voice_engine/

Replace scoped_ptr with unique_ptr in webrtc/voice_engine/

Also introduce a pair of scoped_ptr <-> unique_ptr conversion
functions. By using them judiciously, we can keep these CL:s small and
avoid having to convert enormous amounts of code at once.

BUG=webrtc:5520
Committed: https://crrev.com/b7f89d6e668602e46a20e3a9927790ff34029b2a
Cr-Commit-Position: refs/heads/master@{#11658}

[kwiberg-webrtc, 2016-02-17 15:02:22]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/voice_engine/

Also introduce a pair of scoped_ptr <-> unique_ptr conversion
functions. By using them judiciously, we can keep these CL:s small and
avoid having to convert enormous amounts of code at once.

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/voice_engine/

Also introduce a pair of scoped_ptr <-> unique_ptr conversion
functions. By using them judiciously, we can keep these CL:s small and
avoid having to convert enormous amounts of code at once.

BUG=webrtc:5520
==========

[kwiberg-webrtc, 2016-02-17 15:02:22]

kwiberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org, tommi@webrtc.org

[kwiberg-webrtc, 2016-02-17 15:05:05]

Please review:
  tommi: scoped_ptr.h
  solenberg: the rest

[the sun, 2016-02-17 15:38:54]

LGTM, thanks for doing this.

Could you also make class member unique_ptr:s const, when possible?

[tommi, 2016-02-17 17:15:58]

lgtm

[kwiberg-webrtc, 2016-02-17 18:01:36]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-02-17 18:02:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702983002/1

[commit-bot: I haz the power, 2016-02-17 18:04:22]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/voice_engine/

Also introduce a pair of scoped_ptr <-> unique_ptr conversion
functions. By using them judiciously, we can keep these CL:s small and
avoid having to convert enormous amounts of code at once.

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/voice_engine/

Also introduce a pair of scoped_ptr <-> unique_ptr conversion
functions. By using them judiciously, we can keep these CL:s small and
avoid having to convert enormous amounts of code at once.

BUG=webrtc:5520
==========

[commit-bot: I haz the power, 2016-02-17 18:04:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-17 18:04:31]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/voice_engine/

Also introduce a pair of scoped_ptr <-> unique_ptr conversion
functions. By using them judiciously, we can keep these CL:s small and
avoid having to convert enormous amounts of code at once.

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/voice_engine/

Also introduce a pair of scoped_ptr <-> unique_ptr conversion
functions. By using them judiciously, we can keep these CL:s small and
avoid having to convert enormous amounts of code at once.

BUG=webrtc:5520

Committed: https://crrev.com/b7f89d6e668602e46a20e3a9927790ff34029b2a
Cr-Commit-Position: refs/heads/master@{#11658}
==========

[commit-bot: I haz the power, 2016-02-17 18:04:32]

Patchset 1 (id:??) landed as
https://crrev.com/b7f89d6e668602e46a20e3a9927790ff34029b2a
Cr-Commit-Position: refs/heads/master@{#11658}

[kwiberg-webrtc, 2016-02-17 18:10:12]

On 2016/02/17 15:38:54, the sun wrote:
> Could you also make class member unique_ptr:s const, when possible?

That's certainly a good idea, but would make these CLs more difficult to review,
and, perhaps more importantly, significantly more work to create. I've built a
script that automates a good portion of the work, because there's going to be
dozens of CLs this size before I'm done. Adding more manual steps to the process
is not appealing.