Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1702043002: Remove video-codec max bitrate from TMMBN. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove video-codec max bitrate from TMMBN. TMMBN was capped by configured max bitrate for no apparent reason. Removing this to not require payload-type reconfiguration on new video-codec settings. Actual removal of payload-type reconfiguration will happen in a pending CL. BUG=webrtc:5494 R=stefan@webrtc.org Committed: https://crrev.com/9d0c43242b6c06825316d12fc92e707de2936a20 Cr-Commit-Position: refs/heads/master@{#11639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -61 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 3 chunks +1 line, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 3 chunks +1 line, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 4 chunks +1 line, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.cc View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL
4 years, 10 months ago (2016-02-16 16:16:14 UTC) #1
stefan-webrtc
lgtm
4 years, 10 months ago (2016-02-16 16:59:10 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as 9d0c43242b6c06825316d12fc92e707de2936a20 (presubmit successful).
4 years, 10 months ago (2016-02-16 16:59:42 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 16:59:46 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9d0c43242b6c06825316d12fc92e707de2936a20
Cr-Commit-Position: refs/heads/master@{#11639}

Powered by Google App Engine
This is Rietveld 408576698