Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1701993002: VideoCapturerAndroid: Report onFirstFrameAvailable() for textures as well (Closed)

Created:
4 years, 10 months ago by magjed_webrtc
Modified:
4 years, 10 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Report onFirstFrameAvailable() for textures as well We currently only trigger onFirstFrameAvailable() for byte buffer frames. R=perkj@webrtc.org Committed: https://crrev.com/f45381e1e54cc085cf6a98301056fffae6799998 Cr-Commit-Position: refs/heads/master@{#11670}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
magjed_webrtc
perkj - Please take a look.
4 years, 10 months ago (2016-02-16 14:01:03 UTC) #1
magjed_webrtc
perkj - Please take a look.
4 years, 10 months ago (2016-02-18 09:49:25 UTC) #4
perkj_webrtc
Thanks- please add test for this as well. There is a test for none texture ...
4 years, 10 months ago (2016-02-18 11:12:34 UTC) #5
perkj_webrtc
On 2016/02/18 11:12:34, perkj_webrtc wrote: > Thanks- please add test for this as well. There ...
4 years, 10 months ago (2016-02-18 11:12:47 UTC) #6
magjed_webrtc
Added a test and verified that it fails without this CL.
4 years, 10 months ago (2016-02-18 12:06:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701993002/20001
4 years, 10 months ago (2016-02-18 12:06:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11016)
4 years, 10 months ago (2016-02-18 12:17:30 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f45381e1e54cc085cf6a98301056fffae6799998 Cr-Commit-Position: refs/heads/master@{#11670}
4 years, 10 months ago (2016-02-18 14:48:01 UTC) #15
magjed_webrtc
4 years, 10 months ago (2016-02-18 14:48:01 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f45381e1e54cc085cf6a98301056fffae6799998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698