Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: webrtc/base/sslidentity.h

Issue 1701953002: Move SSLIdentity Generate() implementations from .h to .cc file. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Annotate static functions Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/sslidentity.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/sslidentity.h
diff --git a/webrtc/base/sslidentity.h b/webrtc/base/sslidentity.h
index 0f81929cc4e42e20af91ce9c731df706c1fa9715..8793e4b2deb567e19dee9f0a1dfe9fe815a13e93 100644
--- a/webrtc/base/sslidentity.h
+++ b/webrtc/base/sslidentity.h
@@ -201,13 +201,9 @@ class SSLIdentity {
const KeyParams& key_param,
time_t certificate_lifetime);
static SSLIdentity* Generate(const std::string& common_name,
- const KeyParams& key_param) {
- return Generate(common_name, key_param, kDefaultCertificateLifetime);
- }
+ const KeyParams& key_param);
static SSLIdentity* Generate(const std::string& common_name,
- KeyType key_type) {
- return Generate(common_name, KeyParams(key_type));
- }
+ KeyType key_type);
// Generates an identity with the specified validity period.
// TODO(torbjorng): Now that Generate() accepts relevant params, make tests
« no previous file with comments | « no previous file | webrtc/base/sslidentity.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698