Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1701843004: Simplified the function for detecting whether capture data is modified. (Closed)

Created:
4 years, 10 months ago by peah-webrtc
Modified:
4 years, 10 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Simplified the function for detecting whether capture data is modified. BUG= Committed: https://crrev.com/253d8fa82cfdbc1fa7571aa2cb3a9b2e7c2a5864 Cr-Commit-Position: refs/heads/master@{#11704}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -32 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 chunk +9 lines, -32 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
peah-webrtc
4 years, 10 months ago (2016-02-17 09:27:43 UTC) #2
hlundin-webrtc
lgtm https://codereview.webrtc.org/1701843004/diff/1/webrtc/modules/audio_processing/audio_processing_impl.cc File webrtc/modules/audio_processing/audio_processing_impl.cc (left): https://codereview.webrtc.org/1701843004/diff/1/webrtc/modules/audio_processing/audio_processing_impl.cc#oldcode1134 webrtc/modules/audio_processing/audio_processing_impl.cc:1134: bool AudioProcessingImpl::is_data_processed() const { Wow, that was a ...
4 years, 10 months ago (2016-02-18 15:15:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701843004/1
4 years, 10 months ago (2016-02-19 06:34:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11054)
4 years, 10 months ago (2016-02-19 06:45:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701843004/1
4 years, 10 months ago (2016-02-22 08:56:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 10:00:14 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 10:00:22 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/253d8fa82cfdbc1fa7571aa2cb3a9b2e7c2a5864
Cr-Commit-Position: refs/heads/master@{#11704}

Powered by Google App Engine
This is Rietveld 408576698