Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: webrtc/video/vie_channel.h

Issue 1701683002: Move back receiver VCM into ViEChannel. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/vie_channel.h
diff --git a/webrtc/video/vie_channel.h b/webrtc/video/vie_channel.h
index 320ce7c1fc1b1091992c1b847571bbb68a2017ee..369af78862aba7d283db440ebb84ff367eed13de 100644
--- a/webrtc/video/vie_channel.h
+++ b/webrtc/video/vie_channel.h
@@ -67,7 +67,6 @@ class ViEChannel : public VCMFrameTypeCallback,
ViEChannel(Transport* transport,
ProcessThread* module_process_thread,
PayloadRouter* send_payload_router,
- VideoCodingModule* vcm,
RtcpIntraFrameObserver* intra_frame_observer,
RtcpBandwidthObserver* bandwidth_observer,
TransportFeedbackObserver* transport_feedback_observer,
@@ -168,6 +167,7 @@ class ViEChannel : public VCMFrameTypeCallback,
int32_t SetMTU(uint16_t mtu);
// Gets the modules used by the channel.
+ VideoCodingModule* vcm();
RtpRtcp* rtp_rtcp();
ViEReceiver* vie_receiver();
VCMProtectionCallback* vcm_protection_callback();
@@ -357,7 +357,7 @@ class ViEChannel : public VCMFrameTypeCallback,
// Owned modules/classes.
rtc::scoped_ptr<ViEChannelProtectionCallback> vcm_protection_callback_;
- VideoCodingModule* const vcm_;
+ const rtc::scoped_ptr<VideoCodingModule> vcm_;
danilchap 2016/02/15 12:25:09 std::unique_ptr instead of rtc::scoped_ptr is now
pbos-webrtc 2016/02/15 13:04:24 Will replace them all when they've been used more
ViEReceiver vie_receiver_;
ViESyncModule vie_sync_;

Powered by Google App Engine
This is Rietveld 408576698