Move back receiver VCM into ViEChannel.

webrtc/video/video_receive_stream.cc

Index: webrtc/video/video_receive_stream.cc
diff --git a/webrtc/video/video_receive_stream.cc b/webrtc/video/video_receive_stream.cc
index 9046cc6c26d92a60fe831efb09f6c229f8556ba8..0354513bf0d4b533dd867db22e95ae864eb2cf63 100644
--- a/webrtc/video/video_receive_stream.cc
+++ b/webrtc/video/video_receive_stream.cc
@@ -158,7 +158,6 @@ VideoReceiveStream::VideoReceiveStream(
       congestion_controller_(congestion_controller),
       call_stats_(call_stats),
       remb_(remb),
-      vcm_(VideoCodingModule::Create(clock_, nullptr, nullptr)),
       incoming_video_stream_(
           0,
           config.renderer ? config.renderer->SmoothsRenderedFrames() : false),
@@ -166,7 +165,6 @@ VideoReceiveStream::VideoReceiveStream(
       vie_channel_(&transport_adapter_,
                    process_thread,
                    nullptr,
-                   vcm_.get(),
                    nullptr,
                    nullptr,
                    nullptr,
@@ -178,6 +176,7 @@ VideoReceiveStream::VideoReceiveStream(
                    1,
                    false),
       vie_receiver_(vie_channel_.vie_receiver()),
+      vcm_(vie_channel_.vcm()),
       rtp_rtcp_(vie_channel_.rtp_rtcp()) {
   LOG(LS_INFO) << "VideoReceiveStream: " << config_.ToString();
 
@@ -302,14 +301,14 @@ VideoReceiveStream::VideoReceiveStream(
   vie_channel_.SetIncomingVideoStream(&incoming_video_stream_);
   vie_channel_.RegisterPreRenderCallback(this);
 
-  process_thread_->RegisterModule(vcm_.get());
+  process_thread_->RegisterModule(vcm_);

[danilchap, 2016/02/15 12:25:09]

Looks strange that a non-owner object configure and register vcm. Can you put
comment why it is done that way?

[pbos-webrtc, 2016/02/15 13:04:24]

Done.

 }
 
 VideoReceiveStream::~VideoReceiveStream() {
   LOG(LS_INFO) << "~VideoReceiveStream: " << config_.ToString();
   Stop();
 
-  process_thread_->DeRegisterModule(vcm_.get());
+  process_thread_->DeRegisterModule(vcm_);
   vie_channel_.RegisterPreRenderCallback(nullptr);
   vcm_->RegisterPreDecodeImageCallback(nullptr);
 
@@ -377,10 +376,6 @@ void VideoReceiveStream::FrameCallback(VideoFrame* video_frame) {
 
 int VideoReceiveStream::RenderFrame(const uint32_t /*stream_id*/,
                                     const VideoFrame& video_frame) {
-  // TODO(pbos): Wire up config_.render->IsTextureSupported() and convert if not

[danilchap, 2016/02/15 12:25:09]

is it related to this change or rogue cleanup?

[pbos-webrtc, 2016/02/15 13:04:24]

Rogue, added years ago I think.

-  // supported. Or provide methods for converting a texture frame in
-  // VideoFrame.
-
   if (config_.renderer != nullptr)
     config_.renderer->RenderFrame(
         video_frame,