Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1701533002: Move refcount.h and scoped_ref_ptr.h to rtc_base_approved. (Closed)

Created:
4 years, 10 months ago by tommi
Modified:
4 years, 10 months ago
Reviewers:
joachim
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move refcount.h and scoped_ref_ptr.h to rtc_base_approved. BUG= Committed: https://crrev.com/04af839a88fa2e7c8b619a65f2daf8bc5e3910d7 Cr-Commit-Position: refs/heads/master@{#11615}

Patch Set 1 #

Patch Set 2 : Cleanup base.gyp #

Patch Set 3 : Also move scoped_refptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M webrtc/base/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/base/base.gyp View 1 2 4 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
tommi
Cleanup base.gyp
4 years, 10 months ago (2016-02-14 09:30:56 UTC) #1
tommi
4 years, 10 months ago (2016-02-14 09:31:41 UTC) #3
joachim
Thanks, lgtm
4 years, 10 months ago (2016-02-14 09:36:57 UTC) #4
joachim
On 2016/02/14 09:36:57, joachim wrote: > Thanks, lgtm Thinking some more about it, wouldn't it ...
4 years, 10 months ago (2016-02-14 10:53:58 UTC) #5
tommi
Also move scoped_refptr
4 years, 10 months ago (2016-02-14 15:03:32 UTC) #6
tommi
Agreed. ptal.
4 years, 10 months ago (2016-02-14 15:04:32 UTC) #8
joachim
On 2016/02/14 15:04:32, tommi-webrtc wrote: > Agreed. ptal. lgtm
4 years, 10 months ago (2016-02-14 15:50:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701533002/40001
4 years, 10 months ago (2016-02-14 15:52:39 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-14 16:11:13 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-14 16:11:21 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/04af839a88fa2e7c8b619a65f2daf8bc5e3910d7
Cr-Commit-Position: refs/heads/master@{#11615}

Powered by Google App Engine
This is Rietveld 408576698