Boilerplate code addition in order to be able to test upcoming AEC additions

Added boilerplate code for being able to test the upcoming
AEC functionality.

BUG=webrtc:5201
Committed: https://crrev.com/a332e2d3afd67547eb7063394b7168490bc8287e
Cr-Commit-Position: refs/heads/master@{#11647}

[peah-webrtc, 2016-02-16 06:56:15]

Description was changed from

==========
Format changes


Added boilerplate code

BUG=
==========

to

==========
Added boilerplate code for being able to test the upcoming
AEC functionality.

BUG=webrtc:5201
==========

[peah-webrtc, 2016-02-16 07:19:40]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2016-02-16 07:30:10]

peah@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-02-16 07:49:20]

LGTM with a few nits.

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.c (right):

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.c:1868:
self->next_generation_aec_enabled = enable;
In the declaration of self->next_generation_aec_enabled you say that it is
either 0 or 1, no other values. Thus,
self->next_generation_aec_enabled = (enable != 0);

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.c:1872: return
self->next_generation_aec_enabled;
assert(self->next_generation_aec_enabled == 0 ||
self->next_generation_aec_enabled == 1);

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.h (right):

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.h:117: // Returns non-zero if the
next generation aec is
Why not be more specific and define that it returns 1 when enabled?

[peah-webrtc, 2016-02-16 10:24:52]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-02-16 10:24:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1700703005/#ps60001 (title:
"Fixed typo")

[commit-bot: I haz the power, 2016-02-16 10:24:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700703005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700703005/60001

[commit-bot: I haz the power, 2016-02-16 10:29:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 10:29:53]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3449)

[peah-webrtc, 2016-02-16 12:38:42]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-02-16 12:38:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1700703005/#ps80001 (title:
"Merge from master")

[commit-bot: I haz the power, 2016-02-16 12:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700703005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700703005/80001

[commit-bot: I haz the power, 2016-02-16 12:43:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 12:43:17]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3454)

[peah-webrtc, 2016-02-16 12:51:33]

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.c (right):

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.c:1868:
self->next_generation_aec_enabled = enable;
On 2016/02/16 07:49:19, hlundin-webrtc wrote:
> In the declaration of self->next_generation_aec_enabled you say that it is
> either 0 or 1, no other values. Thus,
> self->next_generation_aec_enabled = (enable != 0);

Done.

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.c:1872: return
self->next_generation_aec_enabled;
On 2016/02/16 07:49:20, hlundin-webrtc wrote:
> assert(self->next_generation_aec_enabled == 0 ||
> self->next_generation_aec_enabled == 1);

Done.

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.h (right):

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.h:117: // Returns non-zero if the
next generation aec is
On 2016/02/16 07:49:20, hlundin-webrtc wrote:
> Why not be more specific and define that it returns 1 when enabled?

Done.

[peah-webrtc, 2016-02-16 12:51:34]

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.c (right):

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.c:1868:
self->next_generation_aec_enabled = enable;
On 2016/02/16 07:49:19, hlundin-webrtc wrote:
> In the declaration of self->next_generation_aec_enabled you say that it is
> either 0 or 1, no other values. Thus,
> self->next_generation_aec_enabled = (enable != 0);

Done.

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.c:1872: return
self->next_generation_aec_enabled;
On 2016/02/16 07:49:20, hlundin-webrtc wrote:
> assert(self->next_generation_aec_enabled == 0 ||
> self->next_generation_aec_enabled == 1);

Done.

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.h (right):

https://codereview.webrtc.org/1700703005/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.h:117: // Returns non-zero if the
next generation aec is
On 2016/02/16 07:49:20, hlundin-webrtc wrote:
> Why not be more specific and define that it returns 1 when enabled?

Done.

[peah-webrtc, 2016-02-16 12:52:30]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 12:52:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700703005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700703005/80001

[commit-bot: I haz the power, 2016-02-16 14:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 14:14:48]

Dry run: This issue passed the CQ dry run.

[peah-webrtc, 2016-02-16 14:27:04]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-02-16 14:27:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700703005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700703005/80001

[commit-bot: I haz the power, 2016-02-16 14:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 14:29:41]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3461)

[peah-webrtc, 2016-02-16 15:21:14]

peah@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[peah-webrtc, 2016-02-16 15:21:14]

Adding kjellander@ as you are the OWNER of webrtc/ and the CL includes changes
in webrtc/common.h.

[kjellander_webrtc, 2016-02-16 16:27:40]

On 2016/02/16 15:21:14, peah-webrtc wrote:
> Adding kjellander@ as you are the OWNER of webrtc/ and the CL includes changes
> in webrtc/common.h.

Actually I'm not, just some of the files: 
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/OWNERS

You need to pick a root owner from
https://chromium.googlesource.com/external/webrtc/+/master/OWNERS

[peah-webrtc, 2016-02-16 22:06:26]

peah@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org
- kjellander@webrtc.org

[peah-webrtc, 2016-02-16 22:06:27]

Adding tina.legrand@ as the CL includes changes
in webrtc/common.h.

[tlegrand-webrtc, 2016-02-17 09:06:56]

On 2016/02/16 22:06:27, peah-webrtc wrote:
> Adding tina.legrand@ as the CL includes changes
> in webrtc/common.h.

Nice! lgtm

[tlegrand-webrtc, 2016-02-17 09:06:57]

On 2016/02/16 22:06:27, peah-webrtc wrote:
> Adding tina.legrand@ as the CL includes changes
> in webrtc/common.h.

Nice! lgtm

[peah-webrtc, 2016-02-17 09:09:50]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-02-17 09:09:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700703005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700703005/80001

[commit-bot: I haz the power, 2016-02-17 09:11:19]

Description was changed from

==========
Added boilerplate code for being able to test the upcoming
AEC functionality.

BUG=webrtc:5201
==========

to

==========
Added boilerplate code for being able to test the upcoming
AEC functionality.

BUG=webrtc:5201
==========

[commit-bot: I haz the power, 2016-02-17 09:11:20]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-02-17 09:11:33]

Description was changed from

==========
Added boilerplate code for being able to test the upcoming
AEC functionality.

BUG=webrtc:5201
==========

to

==========
Added boilerplate code for being able to test the upcoming
AEC functionality.

BUG=webrtc:5201

Committed: https://crrev.com/a332e2d3afd67547eb7063394b7168490bc8287e
Cr-Commit-Position: refs/heads/master@{#11647}
==========

[commit-bot: I haz the power, 2016-02-17 09:11:34]

Patchset 4 (id:??) landed as
https://crrev.com/a332e2d3afd67547eb7063394b7168490bc8287e
Cr-Commit-Position: refs/heads/master@{#11647}