webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h - Issue 1699903003: Update bitrate only when we have incoming packet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

Issue 1699903003: Update bitrate only when we have incoming packet. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Clean-up Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc ('K') | « webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h b/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

index 98a68b3dcfefca3b935970e45f845e921aee8556..7145543960df2f89a674816686975f1d560506a6 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

+++ b/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h

@@ -41,10 +41,9 @@ class RemoteEstimatorProxy : public RemoteBitrateEstimator {

size_t payload_size,

const RTPHeader& header,

bool was_paced) override;

- void RemoveStream(unsigned int ssrc) override;

+ void RemoveStream(uint32_t ssrc) override {}

pbos-webrtc 2016/02/16 13:44:34 Can this be removed?

stefan-webrtc 2016/02/16 14:57:16 Nope, implements interface.

bool LatestEstimate(std::vector<unsigned int>* ssrcs,

unsigned int* bitrate_bps) const override;

- bool GetStats(ReceiveBandwidthEstimatorStats* output) const override;

void OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms) override {}

void SetMinBitrate(int min_bitrate_bps) override {}

int64_t TimeUntilNextProcess() override;