Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Unified Diff: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

Issue 1699903003: Update bitrate only when we have incoming packet. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix lint Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
diff --git a/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h b/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
index 4da82659e4d2c5578f76e42356a5561cf48f0a21..c815ee0cfc8d46fc926204405ff5623c232ab56b 100644
--- a/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
+++ b/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
@@ -38,27 +38,6 @@ class RemoteBitrateObserver {
virtual ~RemoteBitrateObserver() {}
};
-struct ReceiveBandwidthEstimatorStats {
- ReceiveBandwidthEstimatorStats() : total_propagation_time_delta_ms(0) {}
-
- // The "propagation_time_delta" of a frame is defined as (d_arrival - d_sent),
- // where d_arrival is the delta of the arrival times of the frame and the
- // previous frame, d_sent is the delta of the sent times of the frame and
- // the previous frame. The sent time is calculated from the RTP timestamp.
-
- // |total_propagation_time_delta_ms| is the sum of the propagation_time_deltas
- // of all received frames, except that it's is adjusted to 0 when it becomes
- // negative.
- int total_propagation_time_delta_ms;
- // The propagation_time_deltas for the frames arrived in the last
- // kProcessIntervalMs using the clock passed to
- // RemoteBitrateEstimatorFactory::Create.
- std::vector<int> recent_propagation_time_delta_ms;
- // The arrival times for the frames arrived in the last kProcessIntervalMs
- // using the clock passed to RemoteBitrateEstimatorFactory::Create.
- std::vector<int64_t> recent_arrival_time_ms;
-};
-
class RemoteBitrateEstimator : public CallStatsObserver, public Module {
public:
static const int kDefaultMinBitrateBps = 30000;
@@ -88,9 +67,6 @@ class RemoteBitrateEstimator : public CallStatsObserver, public Module {
virtual bool LatestEstimate(std::vector<uint32_t>* ssrcs,
uint32_t* bitrate_bps) const = 0;
- // Returns true if the statistics are available.
- virtual bool GetStats(ReceiveBandwidthEstimatorStats* output) const = 0;
-
virtual void SetMinBitrate(int min_bitrate_bps) = 0;
protected:

Powered by Google App Engine
This is Rietveld 408576698