Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1699893002: Stop decoders in VideoReceiveStream destructor. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Stop decoders in VideoReceiveStream destructor. Prevents use-after-free from decoder threads since the VCM outlives ViEChannel. BUG=webrtc:5494 R=danilchap@webrtc.org Committed: https://crrev.com/b1ae3a45d09290ee1d1adc187531ed903821bc4f Cr-Commit-Position: refs/heads/master@{#11628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M webrtc/video/video_receive_stream.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL, I think this might solve https://codereview.webrtc.org/1701683002/ better.
4 years, 10 months ago (2016-02-15 14:51:01 UTC) #1
danilchap
On 2016/02/15 14:51:01, pbos-webrtc wrote: > PTAL, I think this might solve https://codereview.webrtc.org/1701683002/ better. lgtm
4 years, 10 months ago (2016-02-15 16:29:04 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as b1ae3a45d09290ee1d1adc187531ed903821bc4f (presubmit successful).
4 years, 10 months ago (2016-02-15 16:52:55 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 16:52:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1ae3a45d09290ee1d1adc187531ed903821bc4f
Cr-Commit-Position: refs/heads/master@{#11628}

Powered by Google App Engine
This is Rietveld 408576698