Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699043002: [rtp_rtcp] RtcpPacket::Buffer() returns rtc::Buffer instead of scoped_ptr<RawPacket> (Closed)

Created:
4 years, 10 months ago by danilchap
Modified:
4 years, 10 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] RtcpPacket::Build() returns rtc::Buffer instead of scoped_ptr<RawPacket> To be compatible with current code created two temporary classes RawPacket and scoped_ptr<RawPacket> Goal: https://codereview.webrtc.org/1696203002/ BUG=webrtc:5260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -73 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 4 chunks +31 lines, -33 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 2 chunks +8 lines, -40 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
danilchap
4 years, 10 months ago (2016-02-16 10:11:13 UTC) #1 
Description was changed from

==========
[rtp_rtcp] RtcpPacket::Buffer() returns rtc::Buffer instead of
scoped_ptr<RawPacket>

To be compatible with current code created two temporary classes RawPacket and
scoped_ptr<RawPacket>
Goal: https://codereview.webrtc.org/1696203002/

BUG=webrtc:5260
==========

to

==========
[rtp_rtcp] RtcpPacket::Build() returns rtc::Buffer instead of
scoped_ptr<RawPacket>

To be compatible with current code created two temporary classes RawPacket and
scoped_ptr<RawPacket>
Goal: https://codereview.webrtc.org/1696203002/

BUG=webrtc:5260
==========

Powered by Google App Engine
This is Rietveld 408576698