Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1699003002: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/vad/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/vad/ BUG=webrtc:5520 Committed: https://crrev.com/dabf07f4776e3f0658fecd890da0bd55ce5fe6ff Cr-Commit-Position: refs/heads/master@{#11657}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M webrtc/modules/audio_processing/vad/common.h View 1 chunk +2 lines, -0 lines 2 comments Download
M webrtc/modules/audio_processing/vad/pitch_based_vad.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/vad/pole_zero_filter_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/vad/standalone_vad.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/vad/standalone_vad_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/vad/vad_audio_proc.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/vad/vad_circular_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/vad/vad_circular_buffer_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/vad/voice_activity_detector.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-16 13:27:38 UTC) #3
peah-webrtc
https://codereview.webrtc.org/1699003002/diff/1/webrtc/modules/audio_processing/vad/common.h File webrtc/modules/audio_processing/vad/common.h (right): https://codereview.webrtc.org/1699003002/diff/1/webrtc/modules/audio_processing/vad/common.h#newcode15 webrtc/modules/audio_processing/vad/common.h:15: Why is this include needed in the common file? ...
4 years, 10 months ago (2016-02-17 11:54:02 UTC) #4
kwiberg-webrtc
https://codereview.webrtc.org/1699003002/diff/1/webrtc/modules/audio_processing/vad/common.h File webrtc/modules/audio_processing/vad/common.h (right): https://codereview.webrtc.org/1699003002/diff/1/webrtc/modules/audio_processing/vad/common.h#newcode15 webrtc/modules/audio_processing/vad/common.h:15: On 2016/02/17 11:54:01, peah-webrtc wrote: > Why is this ...
4 years, 10 months ago (2016-02-17 12:13:19 UTC) #5
peah-webrtc
On 2016/02/17 12:13:19, kwiberg-webrtc wrote: > https://codereview.webrtc.org/1699003002/diff/1/webrtc/modules/audio_processing/vad/common.h > File webrtc/modules/audio_processing/vad/common.h (right): > > https://codereview.webrtc.org/1699003002/diff/1/webrtc/modules/audio_processing/vad/common.h#newcode15 > ...
4 years, 10 months ago (2016-02-17 12:32:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699003002/1
4 years, 10 months ago (2016-02-17 12:44:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 10 months ago (2016-02-17 14:44:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699003002/1
4 years, 10 months ago (2016-02-17 14:59:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 15:59:50 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 15:59:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dabf07f4776e3f0658fecd890da0bd55ce5fe6ff
Cr-Commit-Position: refs/heads/master@{#11657}

Powered by Google App Engine
This is Rietveld 408576698