Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1698873002: Rename gtest_exclude for rtc_media_unittests. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename gtest_exclude for rtc_media_unittests. Previous suppressions for libjingle_media_unittest stopped working when the target was renamed rtc_media_unittests causing the bots to start flaking. BUG= TBR=kjellander@webrtc.org Committed: https://crrev.com/56e6269e1154155c1e5c7e7959e17bdb134280c3 Cr-Commit-Position: refs/heads/master@{#11624}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
pbos-webrtc
Committed patchset #1 (id:1) manually as 56e6269e1154155c1e5c7e7959e17bdb134280c3 (presubmit successful).
4 years, 10 months ago (2016-02-15 10:59:27 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/56e6269e1154155c1e5c7e7959e17bdb134280c3 Cr-Commit-Position: refs/heads/master@{#11624}
4 years, 10 months ago (2016-02-15 10:59:29 UTC) #4
kjellander_webrtc
lgtm thanks for this. I forgot about these (and they don't show up in git ...
4 years, 10 months ago (2016-02-15 11:54:08 UTC) #5
pbos-webrtc
On 2016/02/15 11:54:08, kjellander (webrtc) wrote: > lgtm > thanks for this. I forgot about ...
4 years, 10 months ago (2016-02-15 11:59:49 UTC) #6
kjellander_webrtc
4 years, 10 months ago (2016-02-15 12:03:47 UTC) #7
Message was sent while issue was closed.
On 2016/02/15 11:59:49, pbos-webrtc wrote:
> On 2016/02/15 11:54:08, kjellander (webrtc) wrote:
> > lgtm
> > thanks for this. I forgot about these (and they don't show up in git grep).
> > I'll do a similar one for libjingle_p2p_unittest renamed in
> > https://codereview.webrtc.org/1694813002/
> 
> They don't seem to trigger any errors yet, can we run this for a week and then
> see if we can remove it instead?

I don't want to sign up for additional maintenance. If we want to try something
out like that, I suggest we do that in a separate bug. This should have been a
part of my renaming CL.

Powered by Google App Engine
This is Rietveld 408576698