Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1698843003: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/transient/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
Reviewers:
aluebs-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/transient/ BUG=webrtc:5520 Committed: https://crrev.com/85d8bb025aa1144f4266e093b0cf009d99ce8dcb Cr-Commit-Position: refs/heads/master@{#11645}

Patch Set 1 #

Patch Set 2 : compile fix #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -88 lines) Patch
M webrtc/modules/audio_processing/transient/click_annotate.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/transient/file_utils.cc View 9 chunks +10 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/transient/file_utils_unittest.cc View 20 chunks +25 lines, -25 lines 0 comments Download
M webrtc/modules/audio_processing/transient/moving_moments.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/moving_moments.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/transient/moving_moments_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_detector.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_detector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_detector_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_suppression_test.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_suppressor.h View 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_suppressor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_node.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_node.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_node_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_tree.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_tree.cc View 2 chunks +1 line, -2 lines 4 comments Download
M webrtc/modules/audio_processing/transient/wpd_tree_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-15 19:42:35 UTC) #3
aluebs-webrtc
lgtm % one small comment https://codereview.webrtc.org/1698843003/diff/20001/webrtc/modules/audio_processing/transient/wpd_tree.cc File webrtc/modules/audio_processing/transient/wpd_tree.cc (left): https://codereview.webrtc.org/1698843003/diff/20001/webrtc/modules/audio_processing/transient/wpd_tree.cc#oldcode17 webrtc/modules/audio_processing/transient/wpd_tree.cc:17: #include "webrtc/base/scoped_ptr.h" Add <memory> ...
4 years, 10 months ago (2016-02-16 16:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698843003/20001
4 years, 10 months ago (2016-02-17 03:05:55 UTC) #6
kwiberg-webrtc
https://codereview.webrtc.org/1698843003/diff/20001/webrtc/modules/audio_processing/transient/wpd_tree.cc File webrtc/modules/audio_processing/transient/wpd_tree.cc (left): https://codereview.webrtc.org/1698843003/diff/20001/webrtc/modules/audio_processing/transient/wpd_tree.cc#oldcode17 webrtc/modules/audio_processing/transient/wpd_tree.cc:17: #include "webrtc/base/scoped_ptr.h" On 2016/02/16 16:20:10, aluebs-webrtc wrote: > Add ...
4 years, 10 months ago (2016-02-17 03:06:30 UTC) #7
aluebs-webrtc
https://codereview.webrtc.org/1698843003/diff/20001/webrtc/modules/audio_processing/transient/wpd_tree.cc File webrtc/modules/audio_processing/transient/wpd_tree.cc (left): https://codereview.webrtc.org/1698843003/diff/20001/webrtc/modules/audio_processing/transient/wpd_tree.cc#oldcode17 webrtc/modules/audio_processing/transient/wpd_tree.cc:17: #include "webrtc/base/scoped_ptr.h" On 2016/02/17 03:06:30, kwiberg-webrtc wrote: > On ...
4 years, 10 months ago (2016-02-17 03:15:59 UTC) #8
kwiberg-webrtc
https://codereview.webrtc.org/1698843003/diff/20001/webrtc/modules/audio_processing/transient/wpd_tree.cc File webrtc/modules/audio_processing/transient/wpd_tree.cc (left): https://codereview.webrtc.org/1698843003/diff/20001/webrtc/modules/audio_processing/transient/wpd_tree.cc#oldcode17 webrtc/modules/audio_processing/transient/wpd_tree.cc:17: #include "webrtc/base/scoped_ptr.h" On 2016/02/17 03:15:59, aluebs-webrtc wrote: > On ...
4 years, 10 months ago (2016-02-17 03:25:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 04:39:40 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 04:39:47 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/85d8bb025aa1144f4266e093b0cf009d99ce8dcb
Cr-Commit-Position: refs/heads/master@{#11645}

Powered by Google App Engine
This is Rietveld 408576698