Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Issue 1698343003: Ignore padding-only RTX packets in test. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ignore padding-only RTX packets in test. Makes DecodesRetransmittedFrame not flake/fail due to sent padding when probing, which is correct behavior. Also removes hack that accepted this only during the first n packets. BUG= R=stefan@webrtc.org Committed: https://crrev.com/67680c1bf9d14b0dd36fedebadac45af68b26278 Cr-Commit-Position: refs/heads/master@{#11648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M webrtc/video/end_to_end_tests.cc View 4 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
stefan-webrtc
lgtm
4 years, 10 months ago (2016-02-17 10:09:48 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as 67680c1bf9d14b0dd36fedebadac45af68b26278 (presubmit successful).
4 years, 10 months ago (2016-02-17 10:10:18 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 10:10:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67680c1bf9d14b0dd36fedebadac45af68b26278
Cr-Commit-Position: refs/heads/master@{#11648}

Powered by Google App Engine
This is Rietveld 408576698