Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1698243003:
Changed order of events when synthesizing a call in audioproc (Closed)
|
Created:
4 years, 10 months ago by peah-webrtc Modified:
4 years, 10 months ago Reviewers:
hlundin-webrtc CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionChanged order of events when synthesizing a call.
This is needed when synthesizing a call based on
48 kHz audio files as otherwise an error is
generated about the wrong sample rate is generated.
That error is in turned caused by the sample rate
being changed from the default 16 kHz
at the first Capture API call event.
BUG=
Committed: https://crrev.com/58cf5f14ec3f2023a6fe2dd5cc84eefacd2a87c6
Cr-Commit-Position: refs/heads/master@{#11635}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Changed if-else statement to conditional #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Changed order of events when synthesizing a call. This is needed when synthesizing a call based on 48 kHz audio files as otherwise an error is generated about the wrong sample rate is generated. That error is in turned caused by the sample rate being changed from the default 16 kHz at the first Capture API call event. BUG= ========== to ========== Changed order of events when synthesizing a call. This is needed when synthesizing a call based on 48 kHz audio files as otherwise an error is generated about the wrong sample rate is generated. That error is in turned caused by the sample rate being changed from the default 16 kHz at the first Capture API call event. BUG= ==========
peah@webrtc.org changed reviewers: + henrik.lundin@webrtc.org
On 2016/02/16 08:27:08, peah-webrtc wrote: Strange wording in the description: "... an error is generated about the wrong sample rate is generated."
LGTM with nit in description and an optional suggestion in the code. https://codereview.webrtc.org/1698243003/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/test/process_test.cc (right): https://codereview.webrtc.org/1698243003/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/test/process_test.cc:843: if (event == kCaptureEvent) { You could also write this as event = (event == kCaptureEvent) ? kRenderEvent : kCaptureEvent;
https://codereview.webrtc.org/1698243003/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/test/process_test.cc (right): https://codereview.webrtc.org/1698243003/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/test/process_test.cc:843: if (event == kCaptureEvent) { On 2016/02/16 12:15:52, hlundin-webrtc wrote: > You could also write this as > event = (event == kCaptureEvent) ? kRenderEvent : kCaptureEvent; Done.
The CQ bit was checked by peah@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrik.lundin@webrtc.org Link to the patchset: https://codereview.webrtc.org/1698243003/#ps20001 (title: "Changed if-else statement to conditional")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698243003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698243003/20001
Message was sent while issue was closed.
Description was changed from ========== Changed order of events when synthesizing a call. This is needed when synthesizing a call based on 48 kHz audio files as otherwise an error is generated about the wrong sample rate is generated. That error is in turned caused by the sample rate being changed from the default 16 kHz at the first Capture API call event. BUG= ========== to ========== Changed order of events when synthesizing a call. This is needed when synthesizing a call based on 48 kHz audio files as otherwise an error is generated about the wrong sample rate is generated. That error is in turned caused by the sample rate being changed from the default 16 kHz at the first Capture API call event. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Changed order of events when synthesizing a call. This is needed when synthesizing a call based on 48 kHz audio files as otherwise an error is generated about the wrong sample rate is generated. That error is in turned caused by the sample rate being changed from the default 16 kHz at the first Capture API call event. BUG= ========== to ========== Changed order of events when synthesizing a call. This is needed when synthesizing a call based on 48 kHz audio files as otherwise an error is generated about the wrong sample rate is generated. That error is in turned caused by the sample rate being changed from the default 16 kHz at the first Capture API call event. BUG= Committed: https://crrev.com/58cf5f14ec3f2023a6fe2dd5cc84eefacd2a87c6 Cr-Commit-Position: refs/heads/master@{#11635} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/58cf5f14ec3f2023a6fe2dd5cc84eefacd2a87c6 Cr-Commit-Position: refs/heads/master@{#11635} |
