Extract ViESyncModule outside ViEChannel.

Extract ViESyncModule outside ViEChannel.

Moves functionality outside ViEChannel and away from the sender.

BUG=webrtc:5494
R=danilchap@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/1794b2675f21997fca08f4e3ca275a276ce15fdd

[pbos-webrtc, 2016-02-15 16:57:51]

PTAL

[danilchap, 2016-02-16 08:54:06]

looks good except probably one function

https://codereview.webrtc.org/1698183002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/1698183002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.cc:356: if (voice_engine != nullptr &&
audio_channel_id != -1) {
Probably better to leave old way of branching to clearly show
ConfigureSync(-1, nullptr,...) and
ConfigureSync(channel_id>=0, sync_interface != nullptr,...) are distinct cases.

[pbos-webrtc, 2016-02-16 10:09:04]

feedback

[pbos-webrtc, 2016-02-16 10:10:23]

PTAL, thanks.

https://codereview.webrtc.org/1698183002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/1698183002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.cc:356: if (voice_engine != nullptr &&
audio_channel_id != -1) {
On 2016/02/16 08:54:06, danilchap wrote:
> Probably better to leave old way of branching to clearly show
> ConfigureSync(-1, nullptr,...) and
> ConfigureSync(channel_id>=0, sync_interface != nullptr,...) are distinct
cases.

Done.

[danilchap, 2016-02-16 10:28:34]

lgtm

lgtm

[commit-bot: I haz the power, 2016-02-16 13:12:15]

Description was changed from

==========
Extract ViESyncModule outside ViEChannel.

Moves functionality outside ViEChannel and away from the sender.

BUG=webrtc:5494
R=danilchap@webrtc.org
==========

to

==========
Extract ViESyncModule outside ViEChannel.

Moves functionality outside ViEChannel and away from the sender.

BUG=webrtc:5494
R=danilchap@webrtc.org

Committed: https://crrev.com/1794b2675f21997fca08f4e3ca275a276ce15fdd
Cr-Commit-Position: refs/heads/master@{#11633}
==========

[pbos-webrtc, 2016-02-16 13:12:15]

Description was changed from

==========
Extract ViESyncModule outside ViEChannel.

Moves functionality outside ViEChannel and away from the sender.

BUG=webrtc:5494
R=danilchap@webrtc.org

Committed: https://crrev.com/1794b2675f21997fca08f4e3ca275a276ce15fdd
Cr-Commit-Position: refs/heads/master@{#11633}
==========

to

==========
Extract ViESyncModule outside ViEChannel.

Moves functionality outside ViEChannel and away from the sender.

BUG=webrtc:5494
R=danilchap@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1794b2675f21997fca08f4e3c...
==========

[commit-bot: I haz the power, 2016-02-16 13:12:15]

Patchset 2 (id:??) landed as
https://crrev.com/1794b2675f21997fca08f4e3ca275a276ce15fdd
Cr-Commit-Position: refs/heads/master@{#11633}

[pbos-webrtc, 2016-02-16 13:12:17]

Committed patchset #2 (id:20001) manually as
1794b2675f21997fca08f4e3ca275a276ce15fdd (presubmit successful).