Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1698123002: Rename gtest_exclude for rtc_pc_unittests (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename gtest_exclude for rtc_pc_unittests This was forgotten in https://codereview.webrtc.org/1694813002/ Also clean up no-longer-used files for libjignle_unittest (renamed to rtc_unittests a long time ago). BUG=webrtc:5419 TBR=pbos@webrtc.org Committed: https://crrev.com/8110482297b546141fcb7284038dcfbe5e63e491 Cr-Commit-Position: refs/heads/master@{#11625}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
https://codereview.webrtc.org/1698123002/diff/1/tools/valgrind-webrtc/gtest_exclude/libjingle_unittest.gtest-memcheck.txt File tools/valgrind-webrtc/gtest_exclude/libjingle_unittest.gtest-memcheck.txt (left): https://codereview.webrtc.org/1698123002/diff/1/tools/valgrind-webrtc/gtest_exclude/libjingle_unittest.gtest-memcheck.txt#oldcode1 tools/valgrind-webrtc/gtest_exclude/libjingle_unittest.gtest-memcheck.txt:1: # Fails when run under memcheck These are present ...
4 years, 10 months ago (2016-02-15 12:00:27 UTC) #2
kjellander_webrtc
Committed patchset #1 (id:1) manually as 8110482297b546141fcb7284038dcfbe5e63e491 (presubmit successful).
4 years, 10 months ago (2016-02-15 12:01:03 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 12:01:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8110482297b546141fcb7284038dcfbe5e63e491
Cr-Commit-Position: refs/heads/master@{#11625}

Powered by Google App Engine
This is Rietveld 408576698