Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Side by Side Diff: webrtc/base/copyonwritebuffer_unittest.cc

Issue 1697743003: Add CopyOnWriteBuffer class (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: More feedback from kwiberg Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/copyonwritebuffer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "webrtc/base/copyonwritebuffer.h"
12 #include "webrtc/base/gunit.h"
13
14 namespace rtc {
15
16 namespace {
17
18 // clang-format off
19 const uint8_t kTestData[] = {0x0, 0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7,
20 0x8, 0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf};
21 // clang-format on
22
23 } // namespace
24
25 void EnsureBuffersShareData(const CopyOnWriteBuffer& buf1,
26 const CopyOnWriteBuffer& buf2) {
27 // Data is shared between buffers.
28 EXPECT_EQ(buf1.size(), buf2.size());
29 EXPECT_EQ(buf1.capacity(), buf2.capacity());
30 const uint8_t* data1 = buf1.data();
31 const uint8_t* data2 = buf2.data();
32 EXPECT_EQ(data1, data2);
33 EXPECT_EQ(buf1, buf2);
34 }
35
36 void EnsureBuffersDontShareData(const CopyOnWriteBuffer& buf1,
37 const CopyOnWriteBuffer& buf2) {
38 // Data is not shared between buffers.
39 const uint8_t* data1 = buf1.cdata();
40 const uint8_t* data2 = buf2.cdata();
41 EXPECT_NE(data1, data2);
42 }
43
44 TEST(CopyOnWriteBufferTest, TestMoveConstruct) {
45 CopyOnWriteBuffer buf1(kTestData, 3, 10);
46 size_t buf1_size = buf1.size();
47 size_t buf1_capacity = buf1.capacity();
48 const uint8_t* buf1_data = buf1.cdata();
49
50 CopyOnWriteBuffer buf2(std::move(buf1));
51 EXPECT_EQ(buf1.size(), 0u);
52 EXPECT_EQ(buf1.capacity(), 0u);
53 EXPECT_EQ(buf1.data(), nullptr);
54 EXPECT_EQ(buf2.size(), buf1_size);
55 EXPECT_EQ(buf2.capacity(), buf1_capacity);
56 EXPECT_EQ(buf2.data(), buf1_data);
57 }
58
59 TEST(CopyOnWriteBufferTest, TestMoveAssign) {
60 CopyOnWriteBuffer buf1(kTestData, 3, 10);
61 size_t buf1_size = buf1.size();
62 size_t buf1_capacity = buf1.capacity();
63 const uint8_t* buf1_data = buf1.cdata();
64
65 CopyOnWriteBuffer buf2;
66 buf2 = std::move(buf1);
67 EXPECT_EQ(buf1.size(), 0u);
68 EXPECT_EQ(buf1.capacity(), 0u);
69 EXPECT_EQ(buf1.data(), nullptr);
70 EXPECT_EQ(buf2.size(), buf1_size);
71 EXPECT_EQ(buf2.capacity(), buf1_capacity);
72 EXPECT_EQ(buf2.data(), buf1_data);
73 }
74
75 TEST(CopyOnWriteBufferTest, TestSwap) {
76 CopyOnWriteBuffer buf1(kTestData, 3, 10);
77 size_t buf1_size = buf1.size();
78 size_t buf1_capacity = buf1.capacity();
79 const uint8_t* buf1_data = buf1.cdata();
80
81 CopyOnWriteBuffer buf2(kTestData, 6, 20);
82 size_t buf2_size = buf2.size();
83 size_t buf2_capacity = buf2.capacity();
84 const uint8_t* buf2_data = buf2.cdata();
85
86 std::swap(buf1, buf2);
87 EXPECT_EQ(buf1.size(), buf2_size);
88 EXPECT_EQ(buf1.capacity(), buf2_capacity);
89 EXPECT_EQ(buf1.data(), buf2_data);
90 EXPECT_EQ(buf2.size(), buf1_size);
91 EXPECT_EQ(buf2.capacity(), buf1_capacity);
92 EXPECT_EQ(buf2.data(), buf1_data);
93 }
94
95 TEST(CopyOnWriteBufferTest, TestAppendData) {
96 CopyOnWriteBuffer buf1(kTestData, 3, 10);
97 CopyOnWriteBuffer buf2(buf1);
98
99 EnsureBuffersShareData(buf1, buf2);
100
101 // AppendData copies the underlying buffer.
102 buf2.AppendData("foo");
103 EXPECT_EQ(buf2.size(), buf1.size() + 4); // "foo" + trailing 0x00
104 EXPECT_EQ(buf2.capacity(), buf1.capacity());
105 EXPECT_NE(buf2.data(), buf1.data());
106
107 EXPECT_EQ(buf1, CopyOnWriteBuffer(kTestData, 3));
108 const int8_t exp[] = {0x0, 0x1, 0x2, 'f', 'o', 'o', 0x0};
109 EXPECT_EQ(buf2, CopyOnWriteBuffer(exp));
110 }
111
112 TEST(CopyOnWriteBufferTest, TestSetData) {
113 CopyOnWriteBuffer buf1(kTestData, 3, 10);
114 CopyOnWriteBuffer buf2;
115
116 buf2.SetData(buf1);
117 // buf2 shares the same data as buf1 now.
118 EnsureBuffersShareData(buf1, buf2);
119
120 CopyOnWriteBuffer buf3(buf1);
121 // buf3 is re-allocated with new data, existing buffers are not modified.
122 buf3.SetData("foo");
123 EXPECT_EQ(buf1, CopyOnWriteBuffer(kTestData, 3));
124 EnsureBuffersShareData(buf1, buf2);
125 EnsureBuffersDontShareData(buf1, buf3);
126 const int8_t exp[] = {'f', 'o', 'o', 0x0};
127 EXPECT_EQ(buf3, CopyOnWriteBuffer(exp));
128 }
129
130 TEST(CopyOnWriteBufferTest, TestEnsureCapacity) {
131 CopyOnWriteBuffer buf1(kTestData, 3, 10);
132 CopyOnWriteBuffer buf2(buf1);
133
134 // Smaller than existing capacity -> no change and still same contents.
135 buf2.EnsureCapacity(8);
136 EnsureBuffersShareData(buf1, buf2);
137 EXPECT_EQ(buf1.size(), 3u);
138 EXPECT_EQ(buf1.capacity(), 10u);
139 EXPECT_EQ(buf2.size(), 3u);
140 EXPECT_EQ(buf2.capacity(), 10u);
141
142 // Lager than existing capacity -> data is cloned.
143 buf2.EnsureCapacity(16);
144 EnsureBuffersDontShareData(buf1, buf2);
145 EXPECT_EQ(buf1.size(), 3u);
146 EXPECT_EQ(buf1.capacity(), 10u);
147 EXPECT_EQ(buf2.size(), 3u);
148 EXPECT_EQ(buf2.capacity(), 16u);
149 // The size and contents are still the same.
150 EXPECT_EQ(buf1, buf2);
151 }
152
153 TEST(CopyOnWriteBufferTest, TestSetSize) {
154 CopyOnWriteBuffer buf1(kTestData, 3, 10);
155 CopyOnWriteBuffer buf2(buf1);
156
157 buf2.SetSize(16);
158 EnsureBuffersDontShareData(buf1, buf2);
159 EXPECT_EQ(buf1.size(), 3u);
160 EXPECT_EQ(buf1.capacity(), 10u);
161 EXPECT_EQ(buf2.size(), 16u);
162 EXPECT_EQ(buf2.capacity(), 16u);
163 // The contents got cloned.
164 EXPECT_EQ(0, memcmp(buf2.data(), kTestData, 3));
165 }
166
167 TEST(CopyOnWriteBufferTest, TestClear) {
168 CopyOnWriteBuffer buf1(kTestData, 3, 10);
169 CopyOnWriteBuffer buf2(buf1);
170
171 buf2.Clear();
172 EnsureBuffersDontShareData(buf1, buf2);
173 EXPECT_EQ(buf1.size(), 3u);
174 EXPECT_EQ(buf1.capacity(), 10u);
175 EXPECT_EQ(0, memcmp(buf1.data(), kTestData, 3));
176 EXPECT_EQ(buf2.size(), 0u);
177 EXPECT_EQ(buf2.capacity(), 0u);
178 }
179
180 TEST(CopyOnWriteBufferTest, TestConstDataAccessor) {
181 CopyOnWriteBuffer buf1(kTestData, 3, 10);
182 CopyOnWriteBuffer buf2(buf1);
183
184 // .cdata() doesn't clone data.
185 const uint8_t* cdata1 = buf1.cdata();
186 const uint8_t* cdata2 = buf2.cdata();
187 EXPECT_EQ(cdata1, cdata2);
188
189 // Non-const .data() clones data if shared.
190 const uint8_t* data1 = buf1.data();
191 const uint8_t* data2 = buf2.data();
192 EXPECT_NE(data1, data2);
193 // buf1 was cloned above.
194 EXPECT_NE(data1, cdata1);
195 // Therefore buf2 was no longer sharing data and was not cloned.
196 EXPECT_EQ(data2, cdata1);
197 }
198
199 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/copyonwritebuffer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698