Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1697093002: Reland of Don't send FEC for H.264 with NACK enabled. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Don't send FEC for H.264 with NACK enabled. (patchset #1 id:1 of https://codereview.webrtc.org/1692783005/ ) Reason for revert: Disabling tests on memcheck that time out due to using real VP8 encoders. Original issue's description: > Revert of Don't send FEC for H.264 with NACK enabled. (patchset #5 id:80001 of https://codereview.webrtc.org/1687303002/ ) > > Reason for revert: > Broke the VerifyHistogramStatsWithRed test on the Windows DrMemory Full bot and Linux Memcheck bot. Please fix the test and reland. > > Original issue's description: > > Don't send FEC for H.264 with NACK enabled. > > > > The H.264 does not contain picture IDs and are not sufficient to > > determine that a packet may be skipped. This causes retransmission > > requests for FEC that are currently dropped by the sender (since they > > should be redundant). > > > > The receiver is then unable to continue without having the packet gap > > filled (unlike VP8/VP9 which moves on since it has a consecutive stream > > of picture IDs). > > > > Even if FEC retransmission did work it's a huge waste of bandwidth, > > since it just adds additional overhead that has to be unconditionally > > transmitted. This bandwidth is better used to send higher-quality > > frames. > > > > BUG=webrtc:5264 > > R=stefan@webrtc.org > > > > Committed: https://crrev.com/25558ad819b4df41ba51537e26a77480ace1e525 > > Cr-Commit-Position: refs/heads/master@{#11601} > > TBR=stefan@webrtc.org,pbos@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5264 > > Committed: https://crrev.com/29ffdc1a15e31bd81e806ff135c2100d811714f0 > Cr-Commit-Position: refs/heads/master@{#11607} TBR=stefan@webrtc.org,deadbeef@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5264 Committed: https://crrev.com/395939781baa2f338c0ace8d4bb45dcdecc03220 Cr-Commit-Position: refs/heads/master@{#11621}

Patch Set 1 #

Patch Set 2 : Disable EndToEndTest.VerifyHistogramStatsWithRed under memcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -50 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-memcheck.txt View 1 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 7 chunks +25 lines, -7 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 3 chunks +44 lines, -10 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 6 chunks +88 lines, -30 lines 0 comments Download
M webrtc/video/vie_channel.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
Created Reland of Don't send FEC for H.264 with NACK enabled.
4 years, 10 months ago (2016-02-15 10:17:07 UTC) #1
pbos-webrtc
Disable EndToEndTest.VerifyHistogramStatsWithRed under memcheck
4 years, 10 months ago (2016-02-15 10:21:49 UTC) #2
pbos-webrtc
Committed patchset #2 (id:130001) manually as 395939781baa2f338c0ace8d4bb45dcdecc03220 (presubmit successful).
4 years, 10 months ago (2016-02-15 10:27:28 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 10:27:30 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/395939781baa2f338c0ace8d4bb45dcdecc03220
Cr-Commit-Position: refs/heads/master@{#11621}

Powered by Google App Engine
This is Rietveld 408576698