Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1696933003: When doing continual gathering, remove local candidates when a network is dropped. (Closed)

Created:
4 years, 10 months ago by honghaiz3
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

When doing continual gathering, remove the local ports when a corresponding network is dropped. BUG= Committed: https://crrev.com/e3c6c827179e9a340154338aad182604d4546079 Cr-Commit-Position: refs/heads/master@{#11660}

Patch Set 1 : #

Patch Set 2 : Merged with head #

Patch Set 3 : Fix a type conversion error on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -11 lines) Patch
M webrtc/base/network.h View 2 chunks +11 lines, -1 line 0 comments Download
M webrtc/base/network.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/base/network_unittest.cc View 6 chunks +17 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 3 chunks +24 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M webrtc/p2p/base/port.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/port.cc View 1 3 chunks +10 lines, -3 lines 0 comments Download
M webrtc/p2p/base/portinterface.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
honghaiz3
This CL was split from the previous big CL that tried to remove both local ...
4 years, 10 months ago (2016-02-16 19:46:32 UTC) #5
Taylor Brandstetter
lgtm
4 years, 10 months ago (2016-02-17 01:30:51 UTC) #7
pthatcher1
lgtm
4 years, 10 months ago (2016-02-17 06:49:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696933003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696933003/60001
4 years, 10 months ago (2016-02-17 17:53:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/12712) mac_gn_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-17 17:54:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696933003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696933003/80001
4 years, 10 months ago (2016-02-17 18:24:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/12551)
4 years, 10 months ago (2016-02-17 18:38:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696933003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696933003/100001
4 years, 10 months ago (2016-02-17 18:53:45 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 10 months ago (2016-02-17 21:00:32 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 21:00:44 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e3c6c827179e9a340154338aad182604d4546079
Cr-Commit-Position: refs/heads/master@{#11660}

Powered by Google App Engine
This is Rietveld 408576698