Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: webrtc/api/objc/RTCVideoTrack.mm

Issue 1696673003: Tweaks for new Objective-C API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Don't use object subscripting Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/objc/RTCVideoRenderer.h ('k') | webrtc/api/objctests/RTCIceServerTest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/objc/RTCVideoTrack.mm
diff --git a/webrtc/api/objc/RTCVideoTrack.mm b/webrtc/api/objc/RTCVideoTrack.mm
index 7422eff926ec44808dff11dc10ff1fb947ee2925..8a9e3d7fd605c2554074c1251665d682defd3e57 100644
--- a/webrtc/api/objc/RTCVideoTrack.mm
+++ b/webrtc/api/objc/RTCVideoTrack.mm
@@ -33,21 +33,19 @@
rtc::scoped_refptr<webrtc::VideoTrackInterface> track =
factory.nativeFactory->CreateVideoTrack(nativeId,
source.nativeVideoSource);
- return [self initWithNativeTrack:track type:RTCMediaStreamTrackTypeVideo];
+ if ([self initWithNativeTrack:track type:RTCMediaStreamTrackTypeVideo]) {
+ _source = source;
+ }
+ return self;
}
-- (instancetype)initWithNativeMediaTrack:
+- (instancetype)initWithNativeTrack:
(rtc::scoped_refptr<webrtc::MediaStreamTrackInterface>)nativeMediaTrack
- type:(RTCMediaStreamTrackType)type {
+ type:(RTCMediaStreamTrackType)type {
NSParameterAssert(nativeMediaTrack);
NSParameterAssert(type == RTCMediaStreamTrackTypeVideo);
if (self = [super initWithNativeTrack:nativeMediaTrack type:type]) {
_adapters = [NSMutableArray array];
- rtc::scoped_refptr<webrtc::VideoSourceInterface> source =
- self.nativeVideoTrack->GetSource();
- if (source) {
- _source = [[RTCVideoSource alloc] initWithNativeVideoSource:source.get()];
- }
}
return self;
}
@@ -58,6 +56,17 @@
}
}
+- (RTCVideoSource *)source {
+ if (!_source) {
+ rtc::scoped_refptr<webrtc::VideoSourceInterface> source =
+ self.nativeVideoTrack->GetSource();
+ if (source) {
+ _source = [[RTCVideoSource alloc] initWithNativeVideoSource:source.get()];
+ }
+ }
+ return _source;
+}
+
- (void)addRenderer:(id<RTCVideoRenderer>)renderer {
// Make sure we don't have this renderer yet.
for (RTCVideoRendererAdapter *adapter in _adapters) {
@@ -74,7 +83,6 @@
}
- (void)removeRenderer:(id<RTCVideoRenderer>)renderer {
- RTCVideoRendererAdapter *adapter;
__block NSUInteger indexToRemove = NSNotFound;
[_adapters enumerateObjectsUsingBlock:^(RTCVideoRendererAdapter *adapter,
NSUInteger idx,
@@ -87,7 +95,9 @@
if (indexToRemove == NSNotFound) {
return;
}
- self.nativeVideoTrack->RemoveRenderer(adapter.nativeVideoRenderer);
+ RTCVideoRendererAdapter *adapterToRemove =
+ [_adapters objectAtIndex:indexToRemove];
+ self.nativeVideoTrack->RemoveRenderer(adapterToRemove.nativeVideoRenderer);
[_adapters removeObjectAtIndex:indexToRemove];
}
« no previous file with comments | « webrtc/api/objc/RTCVideoRenderer.h ('k') | webrtc/api/objctests/RTCIceServerTest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698