Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: webrtc/api/objc/RTCVideoFrame.h

Issue 1696673003: Tweaks for new Objective-C API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Couple more tweaks after updating against master Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/objc/RTCVideoFrame.h
diff --git a/webrtc/api/objc/RTCVideoFrame.h b/webrtc/api/objc/RTCVideoFrame.h
index c71029051a76efc6eac0fa990d1736523bf4bc34..d3b188e28e63fe52477f1e33e3c924899c826305 100644
--- a/webrtc/api/objc/RTCVideoFrame.h
+++ b/webrtc/api/objc/RTCVideoFrame.h
@@ -16,20 +16,20 @@ NS_ASSUME_NONNULL_BEGIN
@interface RTCVideoFrame : NSObject
/** Width without rotation applied. */
-@property(nonatomic, readonly) size_t width;
+@property(nonatomic, assign, readonly) size_t width;
tkchin_webrtc 2016/02/26 00:45:25 ditto no assign + readonly
/** Height without rotation applied. */
-@property(nonatomic, readonly) size_t height;
-@property(nonatomic, readonly) size_t chromaWidth;
-@property(nonatomic, readonly) size_t chromaHeight;
-@property(nonatomic, readonly) size_t chromaSize;
+@property(nonatomic, assign, readonly) size_t height;
+@property(nonatomic, assign, readonly) size_t chromaWidth;
+@property(nonatomic, assign, readonly) size_t chromaHeight;
+@property(nonatomic, assign, readonly) size_t chromaSize;
// These can return NULL if the object is not backed by a buffer.
@property(nonatomic, readonly, nullable) const uint8_t *yPlane;
@property(nonatomic, readonly, nullable) const uint8_t *uPlane;
@property(nonatomic, readonly, nullable) const uint8_t *vPlane;
-@property(nonatomic, readonly) int32_t yPitch;
-@property(nonatomic, readonly) int32_t uPitch;
-@property(nonatomic, readonly) int32_t vPitch;
+@property(nonatomic, assign, readonly) int32_t yPitch;
+@property(nonatomic, assign, readonly) int32_t uPitch;
+@property(nonatomic, assign, readonly) int32_t vPitch;
- (nonnull instancetype)init NS_UNAVAILABLE;

Powered by Google App Engine
This is Rietveld 408576698