Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: webrtc/api/objc/RTCDataChannel.h

Issue 1696673003: Tweaks for new Objective-C API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Couple more tweaks after updating against master Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/objc/RTCDataChannel.h
diff --git a/webrtc/api/objc/RTCDataChannel.h b/webrtc/api/objc/RTCDataChannel.h
index 61d41bab731e709d05ba50ed99c4bb2beff1c20e..66203715953ccdcaf83c2159f260e6764d7b2ead 100644
--- a/webrtc/api/objc/RTCDataChannel.h
+++ b/webrtc/api/objc/RTCDataChannel.h
@@ -18,7 +18,7 @@ NS_ASSUME_NONNULL_BEGIN
@property(nonatomic, readonly) NSData *data;
/** Indicates whether |data| contains UTF-8 or binary data. */
-@property(nonatomic, readonly) BOOL isBinary;
+@property(nonatomic, assign, readonly) BOOL isBinary;
- (instancetype)init NS_UNAVAILABLE;
@@ -68,18 +68,18 @@ typedef NS_ENUM(NSInteger, RTCDataChannelState) {
@property(nonatomic, readonly) NSString *label;
/** Returns whether this data channel is ordered or not. */
-@property(nonatomic, readonly) BOOL isOrdered;
+@property(nonatomic, assign, readonly) BOOL isOrdered;
tkchin_webrtc 2016/02/26 00:45:24 don't need assign for readonly stuff since assign
/**
* The length of the time window (in milliseconds) during which transmissions
* and retransmissions may occur in unreliable mode.
*/
-@property(nonatomic, readonly) uint16_t maxPacketLifeTime;
+@property(nonatomic, assign, readonly) uint16_t maxPacketLifeTime;
/**
* The maximum number of retransmissions that are attempted in unreliable mode.
*/
-@property(nonatomic, readonly) uint16_t maxRetransmits;
+@property(nonatomic, assign, readonly) uint16_t maxRetransmits;
/**
* The name of the sub-protocol used with this data channel, if any. Otherwise
@@ -90,19 +90,19 @@ typedef NS_ENUM(NSInteger, RTCDataChannelState) {
/**
* Returns whether this data channel was negotiated by the application or not.
*/
-@property(nonatomic, readonly) BOOL isNegotiated;
+@property(nonatomic, assign, readonly) BOOL isNegotiated;
/** The identifier for this data channel. */
-@property(nonatomic, readonly) int id;
+@property(nonatomic, assign, readonly) int channelId;
/** The state of the data channel. */
-@property(nonatomic, readonly) RTCDataChannelState readyState;
+@property(nonatomic, assign, readonly) RTCDataChannelState readyState;
/**
* The number of bytes of application data that have been queued using
* |sendData:| but that have not yet been transmitted to the network.
*/
-@property(nonatomic, readonly) uint64_t bufferedAmount;
+@property(nonatomic, assign, readonly) uint64_t bufferedAmount;
/** The delegate for this data channel. */
@property(nonatomic, weak) id<RTCDataChannelDelegate> delegate;

Powered by Google App Engine
This is Rietveld 408576698