Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: webrtc/api/objc/RTCStatsReport.h

Issue 1696673003: Tweaks for new Objective-C API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Couple more tweaks after updating against master Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import <Foundation/Foundation.h> 11 #import <Foundation/Foundation.h>
12 12
13 NS_ASSUME_NONNULL_BEGIN 13 NS_ASSUME_NONNULL_BEGIN
14 // TODO(hjon): Update nullability types. See http://crbug/webrtc/5592 14 // TODO(hjon): Update nullability types. See http://crbug/webrtc/5592
15 15
16 /** This does not currently conform to the spec. */ 16 /** This does not currently conform to the spec. */
17 @interface RTCStatsReport : NSObject 17 @interface RTCStatsReport : NSObject
18 18
19 /** Time since 1970-01-01T00:00:00Z in milliseconds. */ 19 /** Time since 1970-01-01T00:00:00Z in milliseconds. */
20 @property(nonatomic, readonly) CFTimeInterval timestamp; 20 @property(nonatomic, assign, readonly) CFTimeInterval timestamp;
tkchin_webrtc 2016/02/26 00:45:25 ditto no assign + readonly
21 21
22 /** The type of stats held by this object. */ 22 /** The type of stats held by this object. */
23 @property(nonatomic, readonly) NSString *type; 23 @property(nonatomic, readonly) NSString *type;
24 24
25 /** The identifier for this object. */ 25 /** The identifier for this object. */
26 @property(nonatomic, readonly) NSString *statsId; 26 @property(nonatomic, readonly) NSString *statsId;
27 27
28 /** A dictionary holding the actual stats. */ 28 /** A dictionary holding the actual stats. */
29 @property(nonatomic, readonly) NSDictionary *values; 29 @property(nonatomic, readonly) NSDictionary *values;
30 // @property(nonatomic, readonly) NSDictionary<NSString *, NSString *> *values; 30 // @property(nonatomic, readonly) NSDictionary<NSString *, NSString *> *values;
31 31
32 - (instancetype)init NS_UNAVAILABLE; 32 - (instancetype)init NS_UNAVAILABLE;
33 33
34 @end 34 @end
35 35
36 NS_ASSUME_NONNULL_END 36 NS_ASSUME_NONNULL_END
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698