Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1696153002:
Suppress UBSan errors from the AGC (Closed)
|
Created:
4 years, 10 months ago by peah-webrtc Modified:
4 years, 9 months ago Reviewers:
pbos-webrtc CC:
webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdded the agc digital_agc.c file to the ubsan blacklist
in order to suppress UBSan errors from the AGC.
BUG=webrtc:5124, webrtc:5487, webrtc:5511
Committed: https://crrev.com/1cfe94096cfff9c869c7faf0ab8862ced6019f0e
Cr-Commit-Position: refs/heads/master@{#11730}
Patch Set 1 #Patch Set 2 : Added the analog_agc.c file as well to the blacklist #Patch Set 3 : Merge from master #Messages
Total messages: 20 (12 generated)
Description was changed from ========== Added the agc digital_agc.c file to the ubsan blacklist. BUG=webrtc:5529 ========== to ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5529 ==========
peah@webrtc.org changed reviewers: + pbos@chromium.org
Description was changed from ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5529 ========== to ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5487 ==========
peah@webrtc.org changed reviewers: + pbos@webrtc.org - pbos@chromium.org
Description was changed from ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5487 ========== to ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5124, webrtc:5487 ==========
lgtm, I added another issue to the BUG= field
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696153002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
The CQ bit was checked by peah@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org Link to the patchset: https://codereview.webrtc.org/1696153002/#ps40001 (title: "Merge from master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696153002/40001
Message was sent while issue was closed.
Description was changed from ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5124, webrtc:5487 ========== to ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5124, webrtc:5487 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5124, webrtc:5487 ========== to ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5124, webrtc:5487 Committed: https://crrev.com/1cfe94096cfff9c869c7faf0ab8862ced6019f0e Cr-Commit-Position: refs/heads/master@{#11730} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1cfe94096cfff9c869c7faf0ab8862ced6019f0e Cr-Commit-Position: refs/heads/master@{#11730}
Message was sent while issue was closed.
Description was changed from ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5124, webrtc:5487 Committed: https://crrev.com/1cfe94096cfff9c869c7faf0ab8862ced6019f0e Cr-Commit-Position: refs/heads/master@{#11730} ========== to ========== Added the agc digital_agc.c file to the ubsan blacklist in order to suppress UBSan errors from the AGC. BUG=webrtc:5124, webrtc:5487, webrtc:5511 Committed: https://crrev.com/1cfe94096cfff9c869c7faf0ab8862ced6019f0e Cr-Commit-Position: refs/heads/master@{#11730} ========== |
