Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.cc

Issue 1695743004: Removing the use of the soon-to-be-removed echo_cancellation_impl (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/audio_processing_impl.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc
index b3f38f408ea219f3233809ce232901ac3fa1e4b9..a23cb06a4b4e6716b09a144e134f56fae99ed9d6 100644
--- a/webrtc/modules/audio_processing/audio_processing_impl.cc
+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc
@@ -1380,10 +1380,11 @@ void AudioProcessingImpl::MaybeUpdateHistograms() {
capture_.last_stream_delay_ms = capture_nonlocked_.stream_delay_ms;
// Detect a jump in AEC system delay and log the difference.
- const int frames_per_ms =
+ const int samples_per_ms =
rtc::CheckedDivExact(capture_nonlocked_.split_rate, 1000);
const int aec_system_delay_ms =
- WebRtcAec_system_delay(echo_cancellation()->aec_core()) / frames_per_ms;
+ public_submodules_->echo_cancellation->GetSystemDelayInSamples() /
the sun 2016/02/17 11:39:03 any risk of a div by zero here?
peah-webrtc 2016/03/04 09:46:25 Should be no risk, but adding a DCHECK just in cas
+ samples_per_ms;
const int diff_aec_system_delay_ms =
aec_system_delay_ms - capture_.last_aec_system_delay_ms;
if (diff_aec_system_delay_ms > kMinDiffDelayMs &&

Powered by Google App Engine
This is Rietveld 408576698