Removing the use of the soon-to-be-removed echo_cancellation_impl

Removing the use of the soon-to-be-removed echo_cancellation_impl
 api function that directly returns aec_core.

BUG=webrtc:5201
Committed: https://crrev.com/20028c49c91428929c7c0bc5907e2df3119b6937
Cr-Commit-Position: refs/heads/master@{#11875}

[peah-webrtc, 2016-02-12 22:58:37]

peah@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-02-17 11:39:03]

https://codereview.webrtc.org/1695743004/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1695743004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:1386:
public_submodules_->echo_cancellation->GetSystemDelayInSamples() /
any risk of a div by zero here?

https://codereview.webrtc.org/1695743004/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/echo_cancellation_impl.cc (right):

https://codereview.webrtc.org/1695743004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/echo_cancellation_impl.cc:420: // Report the
delay for the first AEC component.
RTC_DCHECK(is_component_enabled()) ?

[peah-webrtc, 2016-03-04 09:46:25]

https://codereview.webrtc.org/1695743004/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1695743004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:1386:
public_submodules_->echo_cancellation->GetSystemDelayInSamples() /
On 2016/02/17 11:39:03, the sun wrote:
> any risk of a div by zero here?

Should be no risk, but adding a DCHECK just in case.

https://codereview.webrtc.org/1695743004/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/echo_cancellation_impl.cc (right):

https://codereview.webrtc.org/1695743004/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/echo_cancellation_impl.cc:420: // Report the
delay for the first AEC component.
On 2016/02/17 11:39:03, the sun wrote:
> RTC_DCHECK(is_component_enabled()) ?

Done.

[the sun, 2016-03-04 10:05:19]

lgtm

[peah-webrtc, 2016-03-04 10:06:17]

Description was changed from

==========
Removing the use of the soon-to-be-removed echo_cancellation_impl
 api function that directly returns aec_core.



BUG=
==========

to

==========
Removing the use of the soon-to-be-removed echo_cancellation_impl
 api function that directly returns aec_core.



BUG=webrtc:5201
==========

[peah-webrtc, 2016-03-04 10:06:22]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-03-04 10:06:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695743004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695743004/20001

[commit-bot: I haz the power, 2016-03-04 12:07:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 12:07:21]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[peah-webrtc, 2016-03-04 13:49:19]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-03-04 13:49:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695743004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695743004/20001

[commit-bot: I haz the power, 2016-03-04 15:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 15:50:05]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[peah-webrtc, 2016-03-04 19:49:13]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-03-04 19:49:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695743004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695743004/20001

[commit-bot: I haz the power, 2016-03-04 19:50:59]

Description was changed from

==========
Removing the use of the soon-to-be-removed echo_cancellation_impl
 api function that directly returns aec_core.



BUG=webrtc:5201
==========

to

==========
Removing the use of the soon-to-be-removed echo_cancellation_impl
 api function that directly returns aec_core.



BUG=webrtc:5201
==========

[commit-bot: I haz the power, 2016-03-04 19:51:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-04 19:51:07]

Description was changed from

==========
Removing the use of the soon-to-be-removed echo_cancellation_impl
 api function that directly returns aec_core.



BUG=webrtc:5201
==========

to

==========
Removing the use of the soon-to-be-removed echo_cancellation_impl
 api function that directly returns aec_core.

BUG=webrtc:5201

Committed: https://crrev.com/20028c49c91428929c7c0bc5907e2df3119b6937
Cr-Commit-Position: refs/heads/master@{#11875}
==========

[commit-bot: I haz the power, 2016-03-04 19:51:08]

Patchset 2 (id:??) landed as
https://crrev.com/20028c49c91428929c7c0bc5907e2df3119b6937
Cr-Commit-Position: refs/heads/master@{#11875}