Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 1695663003: Drop VideoOptions from VideoSendParameters. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rename send_default_options_ --> default_send_options_. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 webrtc::FecConfig fec; 183 webrtc::FecConfig fec;
184 int rtx_payload_type; 184 int rtx_payload_type;
185 }; 185 };
186 186
187 struct ChangedSendParameters { 187 struct ChangedSendParameters {
188 // These optionals are unset if not changed. 188 // These optionals are unset if not changed.
189 rtc::Optional<VideoCodecSettings> codec; 189 rtc::Optional<VideoCodecSettings> codec;
190 rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions; 190 rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions;
191 rtc::Optional<int> max_bandwidth_bps; 191 rtc::Optional<int> max_bandwidth_bps;
192 rtc::Optional<bool> conference_mode; 192 rtc::Optional<bool> conference_mode;
193 rtc::Optional<VideoOptions> options;
194 rtc::Optional<webrtc::RtcpMode> rtcp_mode; 193 rtc::Optional<webrtc::RtcpMode> rtcp_mode;
195 }; 194 };
196 195
197 struct ChangedRecvParameters { 196 struct ChangedRecvParameters {
198 // These optionals are unset if not changed. 197 // These optionals are unset if not changed.
199 rtc::Optional<std::vector<VideoCodecSettings>> codec_settings; 198 rtc::Optional<std::vector<VideoCodecSettings>> codec_settings;
200 rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions; 199 rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions;
201 rtc::Optional<webrtc::RtcpMode> rtcp_mode; 200 rtc::Optional<webrtc::RtcpMode> rtcp_mode;
202 }; 201 };
203 202
(...skipping 23 matching lines...) Expand all
227 // Wrapper for the sender part, this is where the capturer is connected and 226 // Wrapper for the sender part, this is where the capturer is connected and
228 // frames are then converted from cricket frames to webrtc frames. 227 // frames are then converted from cricket frames to webrtc frames.
229 class WebRtcVideoSendStream 228 class WebRtcVideoSendStream
230 : public rtc::VideoSinkInterface<cricket::VideoFrame>, 229 : public rtc::VideoSinkInterface<cricket::VideoFrame>,
231 public webrtc::LoadObserver { 230 public webrtc::LoadObserver {
232 public: 231 public:
233 WebRtcVideoSendStream( 232 WebRtcVideoSendStream(
234 webrtc::Call* call, 233 webrtc::Call* call,
235 const StreamParams& sp, 234 const StreamParams& sp,
236 const webrtc::VideoSendStream::Config& config, 235 const webrtc::VideoSendStream::Config& config,
236 const VideoOptions& options,
237 WebRtcVideoEncoderFactory* external_encoder_factory, 237 WebRtcVideoEncoderFactory* external_encoder_factory,
238 bool enable_cpu_overuse_detection, 238 bool enable_cpu_overuse_detection,
239 int max_bitrate_bps, 239 int max_bitrate_bps,
240 const rtc::Optional<VideoCodecSettings>& codec_settings, 240 const rtc::Optional<VideoCodecSettings>& codec_settings,
241 const std::vector<webrtc::RtpExtension>& rtp_extensions, 241 const std::vector<webrtc::RtpExtension>& rtp_extensions,
242 const VideoSendParameters& send_params); 242 const VideoSendParameters& send_params);
243 virtual ~WebRtcVideoSendStream(); 243 virtual ~WebRtcVideoSendStream();
244 244
245 void SetOptions(const VideoOptions& options); 245 void SetOptions(const VideoOptions& options);
246 // TODO(pbos): Move logic from SetOptions into this method. 246 // TODO(pbos): Move logic from SetOptions into this method.
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 std::vector<webrtc::RtpExtension> send_rtp_extensions_; 509 std::vector<webrtc::RtpExtension> send_rtp_extensions_;
510 510
511 WebRtcVideoEncoderFactory* const external_encoder_factory_; 511 WebRtcVideoEncoderFactory* const external_encoder_factory_;
512 WebRtcVideoDecoderFactory* const external_decoder_factory_; 512 WebRtcVideoDecoderFactory* const external_decoder_factory_;
513 std::vector<VideoCodecSettings> recv_codecs_; 513 std::vector<VideoCodecSettings> recv_codecs_;
514 std::vector<webrtc::RtpExtension> recv_rtp_extensions_; 514 std::vector<webrtc::RtpExtension> recv_rtp_extensions_;
515 webrtc::Call::Config::BitrateConfig bitrate_config_; 515 webrtc::Call::Config::BitrateConfig bitrate_config_;
516 // TODO(deadbeef): Don't duplicate information between 516 // TODO(deadbeef): Don't duplicate information between
517 // send_params/recv_params, rtp_extensions, options, etc. 517 // send_params/recv_params, rtp_extensions, options, etc.
518 VideoSendParameters send_params_; 518 VideoSendParameters send_params_;
519 VideoOptions default_send_options_;
519 VideoRecvParameters recv_params_; 520 VideoRecvParameters recv_params_;
520 }; 521 };
521 522
522 } // namespace cricket 523 } // namespace cricket
523 524
524 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVIDEOENGINE2_H_ 525 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVIDEOENGINE2_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698