Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: webrtc/pc/channel.cc

Issue 1695663003: Drop VideoOptions from VideoSendParameters. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Let WebRtcVideoChannel2 keep construction-time default VideoOptions. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 params->codecs = desc->codecs(); 134 params->codecs = desc->codecs();
135 } 135 }
136 // TODO(pthatcher): See if we really need 136 // TODO(pthatcher): See if we really need
137 // rtp_header_extensions_set() and remove it if we don't. 137 // rtp_header_extensions_set() and remove it if we don't.
138 if (desc->rtp_header_extensions_set()) { 138 if (desc->rtp_header_extensions_set()) {
139 params->extensions = desc->rtp_header_extensions(); 139 params->extensions = desc->rtp_header_extensions();
140 } 140 }
141 params->rtcp.reduced_size = desc->rtcp_reduced_size(); 141 params->rtcp.reduced_size = desc->rtcp_reduced_size();
142 } 142 }
143 143
144 template <class Codec, class Options> 144 template <class Codec>
145 void RtpSendParametersFromMediaDescription( 145 void RtpSendParametersFromMediaDescription(
146 const MediaContentDescriptionImpl<Codec>* desc, 146 const MediaContentDescriptionImpl<Codec>* desc,
147 RtpSendParameters<Codec, Options>* send_params) { 147 RtpSendParameters<Codec>* send_params) {
148 RtpParametersFromMediaDescription(desc, send_params); 148 RtpParametersFromMediaDescription(desc, send_params);
149 send_params->max_bandwidth_bps = desc->bandwidth(); 149 send_params->max_bandwidth_bps = desc->bandwidth();
150 } 150 }
151 151
152 BaseChannel::BaseChannel(rtc::Thread* thread, 152 BaseChannel::BaseChannel(rtc::Thread* thread,
153 MediaChannel* media_channel, 153 MediaChannel* media_channel,
154 TransportController* transport_controller, 154 TransportController* transport_controller,
155 const std::string& content_name, 155 const std::string& content_name,
156 bool rtcp) 156 bool rtcp)
157 : worker_thread_(thread), 157 : worker_thread_(thread),
(...skipping 2090 matching lines...) Expand 10 before | Expand all | Expand 10 after
2248 return (data_channel_type_ == DCT_RTP) && BaseChannel::ShouldSetupDtlsSrtp(); 2248 return (data_channel_type_ == DCT_RTP) && BaseChannel::ShouldSetupDtlsSrtp();
2249 } 2249 }
2250 2250
2251 void DataChannel::OnStreamClosedRemotely(uint32_t sid) { 2251 void DataChannel::OnStreamClosedRemotely(uint32_t sid) {
2252 rtc::TypedMessageData<uint32_t>* message = 2252 rtc::TypedMessageData<uint32_t>* message =
2253 new rtc::TypedMessageData<uint32_t>(sid); 2253 new rtc::TypedMessageData<uint32_t>(sid);
2254 signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message); 2254 signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message);
2255 } 2255 }
2256 2256
2257 } // namespace cricket 2257 } // namespace cricket
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698