Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: webrtc/pc/channel.cc

Issue 1695663003: Drop VideoOptions from VideoSendParameters. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed pbos' comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 params->codecs = desc->codecs(); 126 params->codecs = desc->codecs();
127 } 127 }
128 // TODO(pthatcher): See if we really need 128 // TODO(pthatcher): See if we really need
129 // rtp_header_extensions_set() and remove it if we don't. 129 // rtp_header_extensions_set() and remove it if we don't.
130 if (desc->rtp_header_extensions_set()) { 130 if (desc->rtp_header_extensions_set()) {
131 params->extensions = desc->rtp_header_extensions(); 131 params->extensions = desc->rtp_header_extensions();
132 } 132 }
133 params->rtcp.reduced_size = desc->rtcp_reduced_size(); 133 params->rtcp.reduced_size = desc->rtcp_reduced_size();
134 } 134 }
135 135
136 template <class Codec, class Options> 136 template <class Codec>
137 void RtpSendParametersFromMediaDescription( 137 void RtpSendParametersFromMediaDescription(
138 const MediaContentDescriptionImpl<Codec>* desc, 138 const MediaContentDescriptionImpl<Codec>* desc,
139 RtpSendParameters<Codec, Options>* send_params) { 139 RtpSendParameters<Codec>* send_params) {
140 RtpParametersFromMediaDescription(desc, send_params); 140 RtpParametersFromMediaDescription(desc, send_params);
141 send_params->max_bandwidth_bps = desc->bandwidth(); 141 send_params->max_bandwidth_bps = desc->bandwidth();
142 } 142 }
143 143
144 BaseChannel::BaseChannel(rtc::Thread* thread, 144 BaseChannel::BaseChannel(rtc::Thread* thread,
145 MediaChannel* media_channel, 145 MediaChannel* media_channel,
146 TransportController* transport_controller, 146 TransportController* transport_controller,
147 const std::string& content_name, 147 const std::string& content_name,
148 bool rtcp) 148 bool rtcp)
149 : worker_thread_(thread), 149 : worker_thread_(thread),
(...skipping 1988 matching lines...) Expand 10 before | Expand all | Expand 10 after
2138 return (data_channel_type_ == DCT_RTP) && BaseChannel::ShouldSetupDtlsSrtp(); 2138 return (data_channel_type_ == DCT_RTP) && BaseChannel::ShouldSetupDtlsSrtp();
2139 } 2139 }
2140 2140
2141 void DataChannel::OnStreamClosedRemotely(uint32_t sid) { 2141 void DataChannel::OnStreamClosedRemotely(uint32_t sid) {
2142 rtc::TypedMessageData<uint32_t>* message = 2142 rtc::TypedMessageData<uint32_t>* message =
2143 new rtc::TypedMessageData<uint32_t>(sid); 2143 new rtc::TypedMessageData<uint32_t>(sid);
2144 signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message); 2144 signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message);
2145 } 2145 }
2146 2146
2147 } // namespace cricket 2147 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698