Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: webrtc/media/base/videoadapter.h

Issue 1695263002: Move direct use of VideoCapturer::VideoAdapter to VideoSinkWants. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: switched to int. Found bug in adapter... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/media/base/videoadapter.cc » ('j') | webrtc/media/base/videobroadcaster.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videoadapter.h
diff --git a/webrtc/media/base/videoadapter.h b/webrtc/media/base/videoadapter.h
index 147a12add5043d034ae21688c53412c7526b6ba3..95f4a66c732cd731313c7614c21517a4b732520d 100644
--- a/webrtc/media/base/videoadapter.h
+++ b/webrtc/media/base/videoadapter.h
@@ -101,11 +101,6 @@ class CoordinatedVideoAdapter
// Enable or disable video adaptation due to the change of the CPU load.
void set_cpu_adaptation(bool enable) { cpu_adaptation_ = enable; }
bool cpu_adaptation() const { return cpu_adaptation_; }
- // Enable or disable smoothing when doing CPU adaptation. When smoothing is
- // enabled, system CPU load is tracked using an exponential weighted
- // average.
- void set_cpu_smoothing(bool enable);
- bool cpu_smoothing() const { return cpu_smoothing_; }
// Enable or disable video adaptation due to the change of the GD
void set_gd_adaptation(bool enable) { gd_adaptation_ = enable; }
bool gd_adaptation() const { return gd_adaptation_; }
@@ -120,31 +115,11 @@ class CoordinatedVideoAdapter
return adapt_reason_;
}
- // When the video is decreased, set the waiting time for CPU adaptation to
- // decrease video again.
- void set_cpu_load_min_samples(int cpu_load_min_samples);
- int cpu_load_min_samples() const { return cpu_load_min_samples_; }
- // CPU system load high threshold for reducing resolution. e.g. 0.85f
- void set_high_system_threshold(float high_system_threshold);
- float high_system_threshold() const { return high_system_threshold_; }
- // CPU system load low threshold for increasing resolution. e.g. 0.70f
- void set_low_system_threshold(float low_system_threshold);
- float low_system_threshold() const { return low_system_threshold_; }
- // CPU process load threshold for reducing resolution. e.g. 0.10f
- void set_process_threshold(float process_threshold);
- float process_threshold() const { return process_threshold_; }
pthatcher1 2016/02/17 23:05:56 Do we not need all this anymore, or did it get mov
perkj_webrtc 2016/02/18 13:22:46 void OnCpuResolutionRequest(AdaptRequest request)
nisse-webrtc 2016/02/18 14:03:42 Would it simplify things with a separate cl deleti
pthatcher1 2016/02/19 06:08:39 That's exactly what I was thinking.
-
// Handle the format request from the server via Jingle update message.
void OnOutputFormatRequest(const VideoFormat& format);
+ void OnLimitResolution(int max_number_of_pixels);
// Handle the resolution request from the encoder due to bandwidth changes.
void OnEncoderResolutionRequest(int width, int height, AdaptRequest request);
- // Handle the resolution request for CPU overuse.
- void OnCpuResolutionRequest(AdaptRequest request);
- // Handle the CPU load provided by a CPU monitor.
- void OnCpuLoadUpdated(int current_cpus, int max_cpus,
- float process_load, float system_load);
-
- sigslot::signal0<> SignalCpuAdaptationUnable;
private:
// Adapt to the minimum of the formats the server requests, the CPU wants, and
@@ -162,14 +137,7 @@ class CoordinatedVideoAdapter
bool gd_adaptation_; // True if gd adaptation is enabled.
bool view_adaptation_; // True if view adaptation is enabled.
bool view_switch_; // True if view switch is enabled.
- int cpu_downgrade_count_;
- int cpu_load_min_samples_;
- int cpu_load_num_samples_;
- // cpu system load thresholds relative to max cpus.
- float high_system_threshold_;
- float low_system_threshold_;
- // cpu process load thresholds relative to current cpus.
- float process_threshold_;
+
// Video formats that the server view requests, the CPU wants, and the encoder
// wants respectively. The adapted output format is the minimum of these.
int view_desired_num_pixels_;
« no previous file with comments | « no previous file | webrtc/media/base/videoadapter.cc » ('j') | webrtc/media/base/videobroadcaster.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698