Index: webrtc/media/engine/webrtcvideoengine2.cc |
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc |
index 0dd8938dc3451758fb0441cb4df457baa6832abe..6e6d1b1f3f588e961860adda94ade2408eb785ae 100644 |
--- a/webrtc/media/engine/webrtcvideoengine2.cc |
+++ b/webrtc/media/engine/webrtcvideoengine2.cc |
@@ -994,13 +994,10 @@ bool WebRtcVideoChannel2::AddSendStream(const StreamParams& sp) { |
send_ssrcs_.insert(used_ssrc); |
webrtc::VideoSendStream::Config config(this); |
- config.overuse_callback = this; |
- |
WebRtcVideoSendStream* stream = new WebRtcVideoSendStream( |
call_, sp, config, external_encoder_factory_, options_, |
- bitrate_config_.max_bitrate_bps, send_codec_, send_rtp_extensions_, |
- send_params_); |
- |
+ signal_cpu_adaptation_, bitrate_config_.max_bitrate_bps, send_codec_, |
+ send_rtp_extensions_, send_params_); |
uint32_t ssrc = sp.first_ssrc(); |
RTC_DCHECK(ssrc != 0); |
send_streams_[ssrc] = stream; |
@@ -1398,26 +1395,6 @@ void WebRtcVideoChannel2::SetInterface(NetworkInterface* iface) { |
kVideoRtpBufferSize); |
} |
-void WebRtcVideoChannel2::OnLoadUpdate(Load load) { |
- // OnLoadUpdate can not take any locks that are held while creating streams |
- // etc. Doing so establishes lock-order inversions between the webrtc process |
- // thread on stream creation and locks such as stream_crit_ while calling out. |
- rtc::CritScope stream_lock(&capturer_crit_); |
- if (!signal_cpu_adaptation_) |
- return; |
- // Do not adapt resolution for screen content as this will likely result in |
- // blurry and unreadable text. |
- for (auto& kv : capturers_) { |
- if (kv.second != nullptr |
- && !kv.second->IsScreencast() |
- && kv.second->video_adapter() != nullptr) { |
- kv.second->video_adapter()->OnCpuResolutionRequest( |
- load == kOveruse ? CoordinatedVideoAdapter::DOWNGRADE |
- : CoordinatedVideoAdapter::UPGRADE); |
- } |
- } |
-} |
- |
bool WebRtcVideoChannel2::SendRtp(const uint8_t* data, |
size_t len, |
const webrtc::PacketOptions& options) { |
@@ -1482,6 +1459,7 @@ WebRtcVideoChannel2::WebRtcVideoSendStream::WebRtcVideoSendStream( |
const webrtc::VideoSendStream::Config& config, |
WebRtcVideoEncoderFactory* external_encoder_factory, |
const VideoOptions& options, |
+ bool enable_cpu_overuse_detection, |
int max_bitrate_bps, |
const rtc::Optional<VideoCodecSettings>& codec_settings, |
const std::vector<webrtc::RtpExtension>& rtp_extensions, |
@@ -1491,6 +1469,7 @@ WebRtcVideoChannel2::WebRtcVideoSendStream::WebRtcVideoSendStream( |
: ssrcs_(sp.ssrcs), |
ssrc_groups_(sp.ssrc_groups), |
call_(call), |
+ load_proxy_(this), |
external_encoder_factory_(external_encoder_factory), |
stream_(NULL), |
parameters_(config, options, max_bitrate_bps, codec_settings), |
@@ -1512,6 +1491,8 @@ WebRtcVideoChannel2::WebRtcVideoSendStream::WebRtcVideoSendStream( |
parameters_.config.rtp.rtcp_mode = send_params.rtcp.reduced_size |
? webrtc::RtcpMode::kReducedSize |
: webrtc::RtcpMode::kCompound; |
+ parameters_.config.overuse_callback = |
+ enable_cpu_overuse_detection ? load_proxy_.proxy() : nullptr; |
if (codec_settings) { |
SetCodecAndOptions(*codec_settings, parameters_.options); |
@@ -1635,9 +1616,6 @@ bool WebRtcVideoChannel2::WebRtcVideoSendStream::DisconnectCapturer() { |
if (capturer_ == NULL) |
return false; |
- if (capturer_->video_adapter() != nullptr) |
- old_adapt_changes_ += capturer_->video_adapter()->adaptation_changes(); |
- |
capturer = capturer_; |
capturer_ = NULL; |
} |
@@ -1929,6 +1907,23 @@ void WebRtcVideoChannel2::WebRtcVideoSendStream::Stop() { |
sending_ = false; |
} |
+void WebRtcVideoChannel2::WebRtcVideoSendStream::OnLoadUpdate(Load load) { |
+ RTC_DCHECK(thread_checker_.CalledOnValidThread()); |
+ LOG(LS_INFO) << "OnLoadUpdate " << load; |
+ if (!capturer_) |
+ return; |
+ sink_wants_.resolution_request.change = |
+ load == kOveruse ? rtc::VideoSinkWants::ResolutionRequest::DOWN |
+ : rtc::VideoSinkWants::ResolutionRequest::UP; |
+ { |
+ rtc::CritScope cs(&lock_); |
+ // TODO(perkj): Resolution should be included as argument in OnLoadUpdate. |
+ sink_wants_.resolution_request.from_height = last_dimensions_.height; |
+ sink_wants_.resolution_request.from_width = last_dimensions_.width; |
+ } |
+ capturer_->AddOrUpdateSink(this, sink_wants_); |
+} |
+ |
VideoSenderInfo |
WebRtcVideoChannel2::WebRtcVideoSendStream::GetVideoSenderInfo() { |
VideoSenderInfo info; |
@@ -1967,10 +1962,6 @@ WebRtcVideoChannel2::WebRtcVideoSendStream::GetVideoSenderInfo() { |
info.input_frame_width = last_captured_frame_format.width; |
info.input_frame_height = last_captured_frame_format.height; |
} |
- if (capturer_->video_adapter() != nullptr) { |
- info.adapt_changes += capturer_->video_adapter()->adaptation_changes(); |
- info.adapt_reason = capturer_->video_adapter()->adapt_reason(); |
- } |
} |
} |