Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 1695263002: Move direct use of VideoCapturer::VideoAdapter to VideoSinkWants. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Tried to address pthatchers comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
index 65b5c6b1e11ebed287b56b050da318527e14fc7b..0037d406639ae3621a70dbc81d11a610aca5d046 100644
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
@@ -1763,18 +1763,33 @@ void WebRtcVideoChannel2Test::TestCpuAdaptation(bool enable_overuse,
FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
webrtc::LoadObserver* overuse_callback =
send_stream->GetConfig().overuse_callback;
+
+ if (!enable_overuse) {
+ ASSERT_TRUE(overuse_callback == NULL);
+
+ EXPECT_TRUE(capturer.CaptureFrame());
+ EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
+
+ EXPECT_EQ(codec.width, send_stream->GetLastWidth());
+ EXPECT_EQ(codec.height, send_stream->GetLastHeight());
+
+ EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, NULL));
+ return;
+ }
+
ASSERT_TRUE(overuse_callback != NULL);
overuse_callback->OnLoadUpdate(webrtc::LoadObserver::kOveruse);
EXPECT_TRUE(capturer.CaptureFrame());
EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
- if (enable_overuse && !is_screenshare) {
- EXPECT_LT(send_stream->GetLastWidth(), codec.width);
- EXPECT_LT(send_stream->GetLastHeight(), codec.height);
- } else {
+ if (is_screenshare) {
+ // Do not adapt screen share.
EXPECT_EQ(codec.width, send_stream->GetLastWidth());
EXPECT_EQ(codec.height, send_stream->GetLastHeight());
+ } else {
+ EXPECT_LT(send_stream->GetLastWidth(), codec.width);
+ EXPECT_LT(send_stream->GetLastHeight(), codec.height);
}
// Trigger underuse which should go back to normal resolution.
« webrtc/media/base/videobroadcaster.cc ('K') | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698