Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: webrtc/media/base/videosourceinterface.h

Issue 1695263002: Move direct use of VideoCapturer::VideoAdapter to VideoSinkWants. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_ 11 #ifndef WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_
12 #define WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_ 12 #define WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_
13 13
14 #include "webrtc/media/base/videosinkinterface.h" 14 #include "webrtc/media/base/videosinkinterface.h"
15 #include "webrtc/base/callback.h" 15 #include "webrtc/base/callback.h"
16 16
17 namespace rtc { 17 namespace rtc {
18 18
19 // VideoSinkWants is used for notifying the source of properties a video frame 19 // VideoSinkWants is used for notifying the source of properties a video frame
20 // should have when it is delivered to a certain sink. 20 // should have when it is delivered to a certain sink.
21 struct VideoSinkWants { 21 struct VideoSinkWants {
22 bool operator==(const VideoSinkWants& rh) const { 22 bool operator==(const VideoSinkWants& rh) const {
23 return rotation_applied == rh.rotation_applied; 23 return rotation_applied == rh.rotation_applied;
24 } 24 }
25 bool operator!=(const VideoSinkWants& rh) const { return !operator==(rh); } 25 bool operator!=(const VideoSinkWants& rh) const { return !operator==(rh); }
26 26
27 // Tells the source whether the sink wants frames with rotation applied. 27 // Tells the source whether the sink wants frames with rotation applied.
28 // By default, the rotation is applied by the source. 28 // By default, the rotation is applied by the source.
29 bool rotation_applied = true; 29 bool rotation_applied = true;
30
31 enum class Resolution {KEEP, UP, DOWN};
32 Resolution resolution = Resolution::KEEP;
nisse-webrtc 2016/02/17 08:19:46 I don't think it's a good idea to have actions her
perkj_webrtc 2016/02/17 17:16:29 After discussions- we don't want to change aspect
30 }; 33 };
31 34
32 template <typename VideoFrameT> 35 template <typename VideoFrameT>
33 class VideoSourceInterface { 36 class VideoSourceInterface {
34 public: 37 public:
35 virtual void AddOrUpdateSink(VideoSinkInterface<VideoFrameT>* sink, 38 virtual void AddOrUpdateSink(VideoSinkInterface<VideoFrameT>* sink,
36 const VideoSinkWants& wants) = 0; 39 const VideoSinkWants& wants) = 0;
37 // RemoveSink must guarantee that at the time the method returns, 40 // RemoveSink must guarantee that at the time the method returns,
38 // there is no current and no future calls to VideoSinkInterface::OnFrame. 41 // there is no current and no future calls to VideoSinkInterface::OnFrame.
39 virtual void RemoveSink(VideoSinkInterface<VideoFrameT>* sink) = 0; 42 virtual void RemoveSink(VideoSinkInterface<VideoFrameT>* sink) = 0;
40 43
41 protected: 44 protected:
42 virtual ~VideoSourceInterface() {} 45 virtual ~VideoSourceInterface() {}
43 }; 46 };
44 47
45 } // namespace rtc 48 } // namespace rtc
46 #endif // WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_ 49 #endif // WEBRTC_MEDIA_BASE_VIDEOSOURCEINTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698