Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1694813002: Rename libjingle_p2p_unittest -> rtc_pc_unittests (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -50 lines) Patch
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/libjingle_p2p_unittest.isolate View 1 chunk +0 lines, -40 lines 0 comments Download
M webrtc/pc/pc_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/rtc_pc_unittests.isolate View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
Needs to be synchronized with landing https://codereview.chromium.org/1697443003
4 years, 10 months ago (2016-02-12 14:44:32 UTC) #3
pthatcher1
lgtm
4 years, 10 months ago (2016-02-12 21:46:10 UTC) #4
kjellander_webrtc
+henrika for root owners of adding the .isolate file.
4 years, 10 months ago (2016-02-15 08:36:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e829f58928eaae6bfcfe2cc090a51d326b70a29d Cr-Commit-Position: refs/heads/master@{#11619}
4 years, 10 months ago (2016-02-15 08:36:51 UTC) #10
kjellander_webrtc
Committed patchset #1 (id:1) manually as e829f58928eaae6bfcfe2cc090a51d326b70a29d.
4 years, 10 months ago (2016-02-15 08:36:52 UTC) #11
henrika_webrtc
4 years, 10 months ago (2016-02-15 08:43:51 UTC) #12
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698