Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1694423002: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/test/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_processing/test/ BUG=webrtc:5520 Committed: https://crrev.com/62eaacf5eec90085e76c66b1bc81f7cd221870a4 Cr-Commit-Position: refs/heads/master@{#11653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -84 lines) Patch
M webrtc/modules/audio_processing/test/audio_file_processor.h View 4 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_file_processor.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 11 chunks +22 lines, -21 lines 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/test/debug_dump_test.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/test/protobuf_utils.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/protobuf_utils.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.h View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/unpack.cc View 5 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-16 14:08:42 UTC) #3
peah-webrtc
On 2016/02/16 14:08:42, kwiberg-webrtc wrote: Nice! lgtm
4 years, 10 months ago (2016-02-17 11:51:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694423002/1
4 years, 10 months ago (2016-02-17 12:09:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 14:39:08 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 14:39:20 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/62eaacf5eec90085e76c66b1bc81f7cd221870a4
Cr-Commit-Position: refs/heads/master@{#11653}

Powered by Google App Engine
This is Rietveld 408576698