Chromium Code Reviews

Issue 1694353003: iOS: Add resource files for tests and implement OutputPath (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, zhuangzesen_agora.io, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, zhengzhonghou_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Add resource files for tests and implement OutputPath With this change the following tests have been successfully passing in the iOS Simulator for iPhone 5 and iOS 9: * audio_decoder_unittests * common_video_unittests * modules_tests * rtc_api_objc_tests * rtc_pc_unittests * system_wrappers_unittests * voice_engine_unittests The modules_unittests and common_audio_unittests are handled in https://codereview.webrtc.org/1698033002/ BUG=webrtc:4755 NOTRY=True Committed: https://crrev.com/0206000a66d8b523f873cd77fb5977da03580dc4 Cr-Commit-Position: refs/heads/master@{#11646}

Patch Set 1 #

Patch Set 2 : Fix ifdef for Android build #

Unified diffs Side-by-side diffs Stats (+107 lines, -13 lines)
M webrtc/build/ios/tests/common_tests.json View 1 chunk +24 lines, -0 lines 0 comments
M webrtc/common_video/common_video_unittests.gyp View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/common_video/libyuv/libyuv_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments
M webrtc/media/media_tests.gypi View 1 chunk +9 lines, -0 lines 0 comments
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/modules/modules.gyp View 1 chunk +8 lines, -0 lines 0 comments
M webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc View 1 chunk +7 lines, -1 line 0 comments
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 7 chunks +15 lines, -4 lines 0 comments
M webrtc/modules/video_coding/test/test_util.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/modules/video_coding/test/tester_main.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/test/testsupport/fileutils.cc View 4 chunks +9 lines, -1 line 0 comments
M webrtc/test/testsupport/iosfileutils.mm View 1 chunk +12 lines, -0 lines 0 comments
M webrtc/webrtc_tests.gypi View 1 chunk +6 lines, -0 lines 0 comments

Messages

Total messages: 15 (10 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-16 13:55:26 UTC) #2
henrika_webrtc
Thanks! LGTM
4 years, 10 months ago (2016-02-16 13:57:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694353003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694353003/80001
4 years, 10 months ago (2016-02-17 06:05:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 10 months ago (2016-02-17 06:06:16 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 06:06:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0206000a66d8b523f873cd77fb5977da03580dc4
Cr-Commit-Position: refs/heads/master@{#11646}

Powered by Google App Engine