Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1693783002:
Add OWNERS file in webrtc/pc (Closed)
|
Created:
4 years, 10 months ago by kjellander_webrtc Modified:
4 years, 10 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd OWNERS file in webrtc/pc
BUG=webrtc:5419
NOTRY=True
R=tommi@webrtc.org
Committed: https://crrev.com/e9de296de820f4e8c6f2cd372b2373d00f4a2880
Cr-Commit-Position: refs/heads/master@{#11599}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
kjellander@webrtc.org changed reviewers: + pthatcher@webrtc.org, tommi@webrtc.org
This is currently the same owners as in talk/ Should we add/remove someone?
Description was changed from ========== Add OWNERS file in webrtc/pc BUG=webrtc:5419 ========== to ========== Add OWNERS file in webrtc/pc BUG=webrtc:5419 ==========
kjellander@webrtc.org changed reviewers: + perkj@webrtc.org
+perkj: do you think I should TBR this?
lgtm
Description was changed from ========== Add OWNERS file in webrtc/pc BUG=webrtc:5419 ========== to ========== Add OWNERS file in webrtc/pc BUG=webrtc:5419 NOTRY=True ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to request the patch to try. Please note that binary files are still unsupported at the moment, this is being worked on. Thanks for your patience. Transient error: No JSON object could be decoded
The CQ bit was unchecked by commit-bot@chromium.org
Description was changed from ========== Add OWNERS file in webrtc/pc BUG=webrtc:5419 NOTRY=True ========== to ========== Add OWNERS file in webrtc/pc BUG=webrtc:5419 NOTRY=True R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/e9de296de820f4e8c6f2cd372... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as e9de296de820f4e8c6f2cd372b2373d00f4a2880 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Add OWNERS file in webrtc/pc BUG=webrtc:5419 NOTRY=True R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/e9de296de820f4e8c6f2cd372... ========== to ========== Add OWNERS file in webrtc/pc BUG=webrtc:5419 NOTRY=True R=tommi@webrtc.org Committed: https://crrev.com/e9de296de820f4e8c6f2cd372b2373d00f4a2880 Cr-Commit-Position: refs/heads/master@{#11599} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e9de296de820f4e8c6f2cd372b2373d00f4a2880 Cr-Commit-Position: refs/heads/master@{#11599} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
