Move simple RtpRtcp calls to VideoSendStream.

Move simple RtpRtcp calls to VideoSendStream.

Moves RtpRtcp module pointers into VideoSendStream and uses them for
simple calls that were only forwarded by ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed: https://crrev.com/723ead844bfd63b3ce6ffdf44abf10682d131ea3
Cr-Commit-Position: refs/heads/master@{#11709}

[pbos-webrtc, 2016-02-11 15:12:40]

Yaaaaaaaaaaaaaaay!

[stefan-webrtc, 2016-02-22 13:11:52]

lgtm

https://codereview.webrtc.org/1693553002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1693553002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:232: const uint16_t mtu =
static_cast<uint16_t>(config_.rtp.max_packet_size + 28);
Make 28 a named constant.

https://codereview.webrtc.org/1693553002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:528:
rtp_rtcp->SetRtxSendStatus(kRtxRetransmitted | kRtxRedundantPayloads);
I think you can move this to line 524 or 517

[pbos-webrtc, 2016-02-22 13:20:45]

feedback

[pbos-webrtc, 2016-02-22 13:21:01]

https://codereview.webrtc.org/1693553002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1693553002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:232: const uint16_t mtu =
static_cast<uint16_t>(config_.rtp.max_packet_size + 28);
On 2016/02/22 13:11:52, stefan-webrtc (holmer) wrote:
> Make 28 a named constant.

Done.

https://codereview.webrtc.org/1693553002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:528:
rtp_rtcp->SetRtxSendStatus(kRtxRetransmitted | kRtxRedundantPayloads);
On 2016/02/22 13:11:52, stefan-webrtc (holmer) wrote:
> I think you can move this to line 524 or 517

Done.

[pbos-webrtc, 2016-02-22 14:14:13]

Description was changed from

==========
Move simple RtpRtcp calls to VideoSendStream.

Moves RtpRtcp module pointers into VideoSendStream and uses them for
simple calls that were only forwarded by ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org
==========

to

==========
Move simple RtpRtcp calls to VideoSendStream.

Moves RtpRtcp module pointers into VideoSendStream and uses them for
simple calls that were only forwarded by ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/723ead844bfd63b3ce6ffdf44...
==========

[pbos-webrtc, 2016-02-22 14:14:14]

Committed patchset #2 (id:20001) manually as
723ead844bfd63b3ce6ffdf44abf10682d131ea3 (presubmit successful).

[commit-bot: I haz the power, 2016-02-22 14:14:18]

Description was changed from

==========
Move simple RtpRtcp calls to VideoSendStream.

Moves RtpRtcp module pointers into VideoSendStream and uses them for
simple calls that were only forwarded by ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/723ead844bfd63b3ce6ffdf44...
==========

to

==========
Move simple RtpRtcp calls to VideoSendStream.

Moves RtpRtcp module pointers into VideoSendStream and uses them for
simple calls that were only forwarded by ViEChannel.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed: https://crrev.com/723ead844bfd63b3ce6ffdf44abf10682d131ea3
Cr-Commit-Position: refs/heads/master@{#11709}
==========

[commit-bot: I haz the power, 2016-02-22 14:14:19]

Patchset 2 (id:??) landed as
https://crrev.com/723ead844bfd63b3ce6ffdf44abf10682d131ea3
Cr-Commit-Position: refs/heads/master@{#11709}