Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1693503002: iOS: Add mb_type config for GYP builders. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
smut
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Add mb_type config for GYP builders. Our first build that passed the configuration reading step failed because of the $(goma_dir) variable. I compared the JSON and the recipes between ours and the builders in chromium.mac and this was the only thing I could easily identify, so I'm going to try it out. Example failing build: https://build.chromium.org/p/client.webrtc.fyi/builders/iOS64%20Simulator%20Debug/builds/97 BUG=chromium:498746 NOTRY=True TBR=smut@google.com Committed: https://crrev.com/a7584c9f7507749a09d1883202c152030888addf Cr-Commit-Position: refs/heads/master@{#11573}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/build/ios/client.webrtc.fyi/iOS32_Debug.json View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/build/ios/client.webrtc.fyi/iOS32_Release.json View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/build/ios/client.webrtc.fyi/iOS32_Simulator_Debug.json View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/build/ios/client.webrtc.fyi/iOS64_Debug.json View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/build/ios/client.webrtc.fyi/iOS64_Release.json View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/build/ios/client.webrtc.fyi/iOS64_Simulator_Debug.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693503002/20001
4 years, 10 months ago (2016-02-11 13:35:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-11 13:36:02 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 13:36:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7584c9f7507749a09d1883202c152030888addf
Cr-Commit-Position: refs/heads/master@{#11573}

Powered by Google App Engine
This is Rietveld 408576698