Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1692243003:
Move RTCFileLogger to webrtc/base/objc. (Closed)
|
Created:
4 years, 10 months ago by hjon_webrtc Modified:
4 years, 9 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMove RTCFileLogger to webrtc/base/objc.
BUG=
R=jiayl@webrtc.org, tkchin@webrtc.org
Committed: https://crrev.com/6140fcc11cb0c6fccf5dcdd3a499409d8f638c1d
Patch from Jon Hjelle <hjon@andyet.net>;.
Cr-Commit-Position: refs/heads/master@{#11754}
Patch Set 1 #Patch Set 2 : Add symlinks #Patch Set 3 : Re-upload of add symlinks #Patch Set 4 : Upload again #Patch Set 5 : Remove symlinks #
Total comments: 2
Patch Set 6 : Fix inadvertent removal #Patch Set 7 : Update app_signaling dependencies #Patch Set 8 : Fix path #
Messages
Total messages: 31 (8 generated)
hjon@webrtc.org changed reviewers: + tkchin@webrtc.org
This was at https://codereview.webrtc.org/1558453002/, but moved under this account for simplicity. Only change from previous CL should be the removal of the NS_ASSUME_NONNULL region.
On 2016/02/13 00:13:25, hjon_webrtc wrote: > This was at https://codereview.webrtc.org/1558453002/, but moved under this > account for simplicity. Only change from previous CL should be the removal of > the NS_ASSUME_NONNULL region. We'll need to get rtc_api_objc compiling for both iOS and Mac first (and we'd need to remove the NS_ASSUME_NONNULL region from all files in webrtc/base/objc currently).
On 2016/02/16 19:13:56, tkchin_webrtc wrote: > On 2016/02/13 00:13:25, hjon_webrtc wrote: > > This was at https://codereview.webrtc.org/1558453002/, but moved under this > > account for simplicity. Only change from previous CL should be the removal of > > the NS_ASSUME_NONNULL region. > > We'll need to get rtc_api_objc compiling for both iOS and Mac first (and we'd > need to remove the NS_ASSUME_NONNULL region from all files in webrtc/base/objc > currently). In addition, we should remove RTCFileLogger from talk/app/webrtc/objc. You can add a symlink for RTCFileLogger.h in talk/app/webrtc/objc/public to the new location though.
Added symlinks. I think the upload worked correctly, though I had some errors the first time and attempting to look at side-by-side diffs doesn't seem to work correctly for those.
On 2016/02/18 17:40:46, hjon_webrtc wrote: > Added symlinks. I think the upload worked correctly, though I had some errors > the first time and attempting to look at side-by-side diffs doesn't seem to work > correctly for those. I can't see the latest stuff, can you re-upload?
I think the upload worked correctly this time.
On 2016/02/19 23:35:21, hjon_webrtc wrote: > I think the upload worked correctly this time. I don't get why RTCFileLogger.h/mm appear twice in talk/app/webrtc/objc. Let's forget the symlink and just leave the header file there as it was before, but delete the .mm from talk/app/webrtc/objc.
Patchset #5 (id:80001) has been deleted
lgtm % nit https://codereview.webrtc.org/1692243003/diff/100001/webrtc/base/objc/RTCFile... File webrtc/base/objc/RTCFileLogger.mm (left): https://codereview.webrtc.org/1692243003/diff/100001/webrtc/base/objc/RTCFile... webrtc/base/objc/RTCFileLogger.mm:49: @synthesize shouldDisableBuffering = _shouldDisableBuffering; add these back?
@tkchin You mentioned we'll need to get rtc_api_objc compiling for iOS and Mac first. Is there anything you want me to do on that front? https://codereview.webrtc.org/1692243003/diff/100001/webrtc/base/objc/RTCFile... File webrtc/base/objc/RTCFileLogger.mm (left): https://codereview.webrtc.org/1692243003/diff/100001/webrtc/base/objc/RTCFile... webrtc/base/objc/RTCFileLogger.mm:49: @synthesize shouldDisableBuffering = _shouldDisableBuffering; On 2016/02/23 00:13:40, tkchin_webrtc wrote: > add these back? Done.
Patchset #6 (id:120001) has been deleted
On 2016/02/23 16:38:37, hjon_webrtc wrote: > @tkchin You mentioned we'll need to get rtc_api_objc compiling for iOS and Mac > first. Is there anything you want me to do on that front? > > https://codereview.webrtc.org/1692243003/diff/100001/webrtc/base/objc/RTCFile... > File webrtc/base/objc/RTCFileLogger.mm (left): > > https://codereview.webrtc.org/1692243003/diff/100001/webrtc/base/objc/RTCFile... > webrtc/base/objc/RTCFileLogger.mm:49: @synthesize shouldDisableBuffering = > _shouldDisableBuffering; > On 2016/02/23 00:13:40, tkchin_webrtc wrote: > > add these back? > > Done. Not for this change I don't think? For the AppRTCDemo check-in yes. I've been slowly figuring out the bot situation. It seems like we are close to the magic configuration we need set up. However, I don't want to block you... if you have time, can you make a CL to just remove all the things the bots are complaining about? See https://codereview.webrtc.org/1713223002/ in the mac_compile_dbg output. Just comment out the things it's complaining about, or add the attributes it's asking for. We'll go back and fix them once the bots are updated.
On 2016/02/23 17:28:45, tkchin_webrtc wrote: > On 2016/02/23 16:38:37, hjon_webrtc wrote: > > @tkchin You mentioned we'll need to get rtc_api_objc compiling for iOS and Mac > > first. Is there anything you want me to do on that front? > > > > > https://codereview.webrtc.org/1692243003/diff/100001/webrtc/base/objc/RTCFile... > > File webrtc/base/objc/RTCFileLogger.mm (left): > > > > > https://codereview.webrtc.org/1692243003/diff/100001/webrtc/base/objc/RTCFile... > > webrtc/base/objc/RTCFileLogger.mm:49: @synthesize shouldDisableBuffering = > > _shouldDisableBuffering; > > On 2016/02/23 00:13:40, tkchin_webrtc wrote: > > > add these back? > > > > Done. > > Not for this change I don't think? For the AppRTCDemo check-in yes. > I've been slowly figuring out the bot situation. It seems like we are close to > the magic configuration we need set up. > > However, I don't want to block you... if you have time, can you make a CL to > just remove all the things the bots are complaining about? > See https://codereview.webrtc.org/1713223002/ in the mac_compile_dbg output. > Just comment out the things it's complaining about, or add the attributes it's > asking for. We'll go back and fix them once the bots are updated. Still lgtm btw.
@tkchin: ptal Also, I got this warning when doing git cl upload: Depending on rtc_base is not allowed. Change your dependency to rtc_base_approved and possibly sanitize and move the desired source file(s) to rtc_base_approved. Changed GYP files: webrtc/webrtc_examples.gyp Should rtc_base_objc depend on rtc_base_approved instead of rtc_base?
lgtm Ignore the webrtc_examples.gyp warning for now - working on fixing that. Meanwhile just commit manually. We can't make rtc_base_objc depend on rtc_base_approved right now because it's missing some stuff we need.
The CQ bit was checked by hjon@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692243003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692243003/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3664)
hjon@webrtc.org changed reviewers: + jiayl@webrtc.org
@jiayl Could you also take a look?
lgtm
Description was changed from ========== Move RTCFileLogger to webrtc/base/objc. BUG= ========== to ========== Move RTCFileLogger to webrtc/base/objc. BUG= R=jiayl@webrtc.org, tkchin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/6140fcc11cb0c6fccf5dcdd3a... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:180001) manually as 6140fcc11cb0c6fccf5dcdd3a499409d8f638c1d.
Message was sent while issue was closed.
Description was changed from ========== Move RTCFileLogger to webrtc/base/objc. BUG= R=jiayl@webrtc.org, tkchin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/6140fcc11cb0c6fccf5dcdd3a... ========== to ========== Move RTCFileLogger to webrtc/base/objc. BUG= R=jiayl@webrtc.org, tkchin@webrtc.org Committed: https://crrev.com/6140fcc11cb0c6fccf5dcdd3a499409d8f638c1d Patch from Jon Hjelle <hjon@andyet.net>. Cr-Commit-Position: refs/heads/master@{#11754} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/6140fcc11cb0c6fccf5dcdd3a499409d8f638c1d Cr-Commit-Position: refs/heads/master@{#11754}
Message was sent while issue was closed.
I am running into build issues which might be related to this change:
[28/943] OBJCXX obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DDISABLE_NACL -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=261368-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1
-DFIELDTRIAL_TESTING_ENABLED -DDISABLE_FTP_SUPPORT=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH
-DWEBRTC_CHROMIUM_BUILD -DLOGGING_INSIDE_WEBRTC -DWEBRTC_POSIX -DWEBRTC_MAC
-DWEBRTC_IOS -DFEATURE_ENABLE_SSL -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H
-DNO_MAIN_THREAD_WRAPPING -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen -I../..
-I../../third_party/webrtc_overrides -I../../third_party -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk
-O0 -gdwarf-2 -Werror -mios-simulator-version-min=7.0 -arch x86_64 -Wall -Wextra
-Wno-unused-parameter -Wno-missing-field-initializers
-Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts
-Wno-unneeded-internal-declaration -Wno-covered-switch-default
-Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register
-Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11
-stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden
-fno-threadsafe-statics -Xclang -load -Xclang
/Users/nicholss/chromoting/crd-base/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-plugin-arg-find-bad-constructs -Xclang follow-macro-expansion
-fcolor-diagnostics -fstack-protector-all -fobjc-arc
-Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors -include
obj/third_party/webrtc/build/rtc_base_objc.WebRTC-Prefix.pch-mm -c
../../third_party/webrtc/base/objc/RTCFileLogger.mm -o
obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o
In file included from ../../third_party/webrtc/base/objc/RTCFileLogger.mm:16:
../../third_party/webrtc/base/logsinks.h:25:36: error: expected class name
class FileRotatingLogSink : public LogSink {
^
../../third_party/webrtc/base/logsinks.h:33:26: error: only virtual member
functions can be marked 'override'
~FileRotatingLogSink() override;
^~~~~~~~
../../third_party/webrtc/base/logsinks.h:37:49: error: only virtual member
functions can be marked 'override'
void OnLogMessage(const std::string& message) override;
^~~~~~~~
../../third_party/webrtc/base/logsinks.h:60:37: error: only virtual member
functions can be marked 'override'
~CallSessionFileRotatingLogSink() override;
^~~~~~~~
../../third_party/webrtc/base/objc/RTCFileLogger.mm:111:20: error: no member
named 'LogThreads' in 'rtc::LogMessage'
rtc::LogMessage::LogThreads(true);
~~~~~~~~~~~~~~~~~^
../../third_party/webrtc/base/objc/RTCFileLogger.mm:112:20: error: no member
named 'LogTimestamps' in 'rtc::LogMessage'
rtc::LogMessage::LogTimestamps(true);
~~~~~~~~~~~~~~~~~^
../../third_party/webrtc/base/objc/RTCFileLogger.mm:113:20: error: no member
named 'AddLogToStream' in 'rtc::LogMessage'
rtc::LogMessage::AddLogToStream(_logSink.get(), [self rtcSeverity]);
~~~~~~~~~~~~~~~~~^
../../third_party/webrtc/base/objc/RTCFileLogger.mm:122:20: error: no member
named 'RemoveLogToStream' in 'rtc::LogMessage'
rtc::LogMessage::RemoveLogToStream(_logSink.get());
~~~~~~~~~~~~~~~~~^
In file included from ../../third_party/webrtc/base/objc/RTCFileLogger.mm:14:
In file included from ../../third_party/webrtc/base/filerotatingstream.h:18:
In file included from ../../third_party/webrtc/base/stream.h:20:
In file included from ../../third_party/webrtc/base/messagehandler.h:17:
../../third_party/webrtc/base/scoped_ptr.h:126:5: error: delete called on
non-final 'rtc::FileRotatingLogSink' that has virtual functions but non-virtual
destructor [-Werror,-Wdelete-non-virtual-dtor]
delete ptr;
^
../../third_party/webrtc/base/scoped_ptr.h:239:7: note: in instantiation of
member function 'rtc::DefaultDeleter<rtc::FileRotatingLogSink>::operator()'
requested here
static_cast<D&>(data_)(old);
^
../../third_party/webrtc/base/scoped_ptr.h:386:49: note: in instantiation of
member function 'rtc::internal::scoped_ptr_impl<rtc::FileRotatingLogSink,
rtc::DefaultDeleter<rtc::FileRotatingLogSink> >::reset' requested here
void reset(element_type* p = nullptr) { impl_.reset(p); }
^
../../third_party/webrtc/base/objc/RTCFileLogger.mm:90:16: note: in
instantiation of member function 'rtc::scoped_ptr<rtc::FileRotatingLogSink,
rtc::DefaultDeleter<rtc::FileRotatingLogSink> >::reset' requested here
_logSink.reset(
^
9 errors generated.
Note: I am getting this breakage in chromium for iOS. This is a regression, I
had no issues working last week.
Message was sent while issue was closed.
On 2016/03/01 17:56:26, nicholss wrote:
> I am running into build issues which might be related to this change:
>
> [28/943] OBJCXX obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o
> FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o.d
> -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DDISABLE_NACL -DCHROMIUM_BUILD
> -DCR_CLANG_REVISION=261368-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1
> -DFIELDTRIAL_TESTING_ENABLED -DDISABLE_FTP_SUPPORT=1
> -DV8_USE_EXTERNAL_STARTUP_DATA -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH
> -DWEBRTC_CHROMIUM_BUILD -DLOGGING_INSIDE_WEBRTC -DWEBRTC_POSIX -DWEBRTC_MAC
> -DWEBRTC_IOS -DFEATURE_ENABLE_SSL -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H
> -DNO_MAIN_THREAD_WRAPPING -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS
> -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
> -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen -I../..
> -I../../third_party/webrtc_overrides -I../../third_party -isysroot
>
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk
> -O0 -gdwarf-2 -Werror -mios-simulator-version-min=7.0 -arch x86_64 -Wall
-Wextra
> -Wno-unused-parameter -Wno-missing-field-initializers
> -Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts
> -Wno-unneeded-internal-declaration -Wno-covered-switch-default
> -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register
> -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11
> -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden
> -fno-threadsafe-statics -Xclang -load -Xclang
>
/Users/nicholss/chromoting/crd-base/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
> -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion
> -fcolor-diagnostics -fstack-protector-all -fobjc-arc
> -Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors -include
> obj/third_party/webrtc/build/rtc_base_objc.WebRTC-Prefix.pch-mm -c
> ../../third_party/webrtc/base/objc/RTCFileLogger.mm -o
> obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o
> In file included from ../../third_party/webrtc/base/objc/RTCFileLogger.mm:16:
> ../../third_party/webrtc/base/logsinks.h:25:36: error: expected class name
> class FileRotatingLogSink : public LogSink {
> ^
> ../../third_party/webrtc/base/logsinks.h:33:26: error: only virtual member
> functions can be marked 'override'
> ~FileRotatingLogSink() override;
> ^~~~~~~~
> ../../third_party/webrtc/base/logsinks.h:37:49: error: only virtual member
> functions can be marked 'override'
> void OnLogMessage(const std::string& message) override;
> ^~~~~~~~
> ../../third_party/webrtc/base/logsinks.h:60:37: error: only virtual member
> functions can be marked 'override'
> ~CallSessionFileRotatingLogSink() override;
> ^~~~~~~~
> ../../third_party/webrtc/base/objc/RTCFileLogger.mm:111:20: error: no member
> named 'LogThreads' in 'rtc::LogMessage'
> rtc::LogMessage::LogThreads(true);
> ~~~~~~~~~~~~~~~~~^
> ../../third_party/webrtc/base/objc/RTCFileLogger.mm:112:20: error: no member
> named 'LogTimestamps' in 'rtc::LogMessage'
> rtc::LogMessage::LogTimestamps(true);
> ~~~~~~~~~~~~~~~~~^
> ../../third_party/webrtc/base/objc/RTCFileLogger.mm:113:20: error: no member
> named 'AddLogToStream' in 'rtc::LogMessage'
> rtc::LogMessage::AddLogToStream(_logSink.get(), [self rtcSeverity]);
> ~~~~~~~~~~~~~~~~~^
> ../../third_party/webrtc/base/objc/RTCFileLogger.mm:122:20: error: no member
> named 'RemoveLogToStream' in 'rtc::LogMessage'
> rtc::LogMessage::RemoveLogToStream(_logSink.get());
> ~~~~~~~~~~~~~~~~~^
> In file included from ../../third_party/webrtc/base/objc/RTCFileLogger.mm:14:
> In file included from ../../third_party/webrtc/base/filerotatingstream.h:18:
> In file included from ../../third_party/webrtc/base/stream.h:20:
> In file included from ../../third_party/webrtc/base/messagehandler.h:17:
> ../../third_party/webrtc/base/scoped_ptr.h:126:5: error: delete called on
> non-final 'rtc::FileRotatingLogSink' that has virtual functions but
non-virtual
> destructor [-Werror,-Wdelete-non-virtual-dtor]
> delete ptr;
> ^
> ../../third_party/webrtc/base/scoped_ptr.h:239:7: note: in instantiation of
> member function 'rtc::DefaultDeleter<rtc::FileRotatingLogSink>::operator()'
> requested here
> static_cast<D&>(data_)(old);
> ^
> ../../third_party/webrtc/base/scoped_ptr.h:386:49: note: in instantiation of
> member function 'rtc::internal::scoped_ptr_impl<rtc::FileRotatingLogSink,
> rtc::DefaultDeleter<rtc::FileRotatingLogSink> >::reset' requested here
> void reset(element_type* p = nullptr) { impl_.reset(p); }
> ^
> ../../third_party/webrtc/base/objc/RTCFileLogger.mm:90:16: note: in
> instantiation of member function 'rtc::scoped_ptr<rtc::FileRotatingLogSink,
> rtc::DefaultDeleter<rtc::FileRotatingLogSink> >::reset' requested here
> _logSink.reset(
> ^
> 9 errors generated.
>
>
>
> Note: I am getting this breakage in chromium for iOS. This is a regression, I
> had no issues working last week.
If I remove RTCFileLogger.h and RTCFileLogger.mm from my build I am back to
working. The above errors are mostly related to RTCFileLogger.h not being able
to find logging.h, so LogSink is not defined.
Message was sent while issue was closed.
On 2016/03/01 18:01:26, nicholss wrote:
> On 2016/03/01 17:56:26, nicholss wrote:
> > I am running into build issues which might be related to this change:
> >
> > [28/943] OBJCXX
obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o
> > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> > obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o.d
> > -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DDISABLE_NACL -DCHROMIUM_BUILD
> > -DCR_CLANG_REVISION=261368-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1
> > -DFIELDTRIAL_TESTING_ENABLED -DDISABLE_FTP_SUPPORT=1
> > -DV8_USE_EXTERNAL_STARTUP_DATA -DWEBRTC_RESTRICT_LOGGING
-DEXPAT_RELATIVE_PATH
> > -DWEBRTC_CHROMIUM_BUILD -DLOGGING_INSIDE_WEBRTC -DWEBRTC_POSIX -DWEBRTC_MAC
> > -DWEBRTC_IOS -DFEATURE_ENABLE_SSL -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H
> > -DNO_MAIN_THREAD_WRAPPING -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS
> > -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
> > -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen -I../..
> > -I../../third_party/webrtc_overrides -I../../third_party -isysroot
> >
>
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk
> > -O0 -gdwarf-2 -Werror -mios-simulator-version-min=7.0 -arch x86_64 -Wall
> -Wextra
> > -Wno-unused-parameter -Wno-missing-field-initializers
> > -Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts
> > -Wno-unneeded-internal-declaration -Wno-covered-switch-default
> > -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register
> > -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11
> > -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden
> > -fno-threadsafe-statics -Xclang -load -Xclang
> >
>
/Users/nicholss/chromoting/crd-base/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> > -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
> > -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
> > -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion
> > -fcolor-diagnostics -fstack-protector-all -fobjc-arc
> > -Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors -include
> > obj/third_party/webrtc/build/rtc_base_objc.WebRTC-Prefix.pch-mm -c
> > ../../third_party/webrtc/base/objc/RTCFileLogger.mm -o
> > obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o
> > In file included from
../../third_party/webrtc/base/objc/RTCFileLogger.mm:16:
> > ../../third_party/webrtc/base/logsinks.h:25:36: error: expected class name
> > class FileRotatingLogSink : public LogSink {
> > ^
> > ../../third_party/webrtc/base/logsinks.h:33:26: error: only virtual member
> > functions can be marked 'override'
> > ~FileRotatingLogSink() override;
> > ^~~~~~~~
> > ../../third_party/webrtc/base/logsinks.h:37:49: error: only virtual member
> > functions can be marked 'override'
> > void OnLogMessage(const std::string& message) override;
> > ^~~~~~~~
> > ../../third_party/webrtc/base/logsinks.h:60:37: error: only virtual member
> > functions can be marked 'override'
> > ~CallSessionFileRotatingLogSink() override;
> > ^~~~~~~~
> > ../../third_party/webrtc/base/objc/RTCFileLogger.mm:111:20: error: no member
> > named 'LogThreads' in 'rtc::LogMessage'
> > rtc::LogMessage::LogThreads(true);
> > ~~~~~~~~~~~~~~~~~^
> > ../../third_party/webrtc/base/objc/RTCFileLogger.mm:112:20: error: no member
> > named 'LogTimestamps' in 'rtc::LogMessage'
> > rtc::LogMessage::LogTimestamps(true);
> > ~~~~~~~~~~~~~~~~~^
> > ../../third_party/webrtc/base/objc/RTCFileLogger.mm:113:20: error: no member
> > named 'AddLogToStream' in 'rtc::LogMessage'
> > rtc::LogMessage::AddLogToStream(_logSink.get(), [self rtcSeverity]);
> > ~~~~~~~~~~~~~~~~~^
> > ../../third_party/webrtc/base/objc/RTCFileLogger.mm:122:20: error: no member
> > named 'RemoveLogToStream' in 'rtc::LogMessage'
> > rtc::LogMessage::RemoveLogToStream(_logSink.get());
> > ~~~~~~~~~~~~~~~~~^
> > In file included from
../../third_party/webrtc/base/objc/RTCFileLogger.mm:14:
> > In file included from ../../third_party/webrtc/base/filerotatingstream.h:18:
> > In file included from ../../third_party/webrtc/base/stream.h:20:
> > In file included from ../../third_party/webrtc/base/messagehandler.h:17:
> > ../../third_party/webrtc/base/scoped_ptr.h:126:5: error: delete called on
> > non-final 'rtc::FileRotatingLogSink' that has virtual functions but
> non-virtual
> > destructor [-Werror,-Wdelete-non-virtual-dtor]
> > delete ptr;
> > ^
> > ../../third_party/webrtc/base/scoped_ptr.h:239:7: note: in instantiation of
> > member function 'rtc::DefaultDeleter<rtc::FileRotatingLogSink>::operator()'
> > requested here
> > static_cast<D&>(data_)(old);
> > ^
> > ../../third_party/webrtc/base/scoped_ptr.h:386:49: note: in instantiation of
> > member function 'rtc::internal::scoped_ptr_impl<rtc::FileRotatingLogSink,
> > rtc::DefaultDeleter<rtc::FileRotatingLogSink> >::reset' requested here
> > void reset(element_type* p = nullptr) { impl_.reset(p); }
> > ^
> > ../../third_party/webrtc/base/objc/RTCFileLogger.mm:90:16: note: in
> > instantiation of member function 'rtc::scoped_ptr<rtc::FileRotatingLogSink,
> > rtc::DefaultDeleter<rtc::FileRotatingLogSink> >::reset' requested here
> > _logSink.reset(
> > ^
> > 9 errors generated.
> >
> >
> >
> > Note: I am getting this breakage in chromium for iOS. This is a regression,
I
> > had no issues working last week.
>
> If I remove RTCFileLogger.h and RTCFileLogger.mm from my build I am back to
> working. The above errors are mostly related to RTCFileLogger.h not being able
> to find logging.h, so LogSink is not defined.
I have filed a bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=5611
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
