Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1691953004:
Add VP9 to full stack tests. (Closed)
|
Created:
4 years, 10 months ago by åsapersson Modified:
4 years, 10 months ago CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd VP9 to full stack tests.
BUG=
Committed: https://crrev.com/88b0a2292a1f0331055cdfb193dacc43526a2367
Cr-Commit-Position: refs/heads/master@{#11608}
Patch Set 1 #Patch Set 2 : #
Total comments: 2
Patch Set 3 : #Patch Set 4 : #Patch Set 5 : add two vp9 tests for now #Messages
Total messages: 31 (16 generated)
Patchset #2 (id:10001) has been deleted
Description was changed from ========== Add VP9 to full stack tests. BUG= ========== to ========== Add VP9 to full stack tests. BUG= ==========
asapersson@webrtc.org changed reviewers: + pbos@webrtc.org
pbos@webrtc.org changed reviewers: + kjellander@webrtc.org
LGTM, I think this is good coverage to have. +R kjellander@ since this will add non-zero runtime to our bots. https://codereview.webrtc.org/1691953004/diff/30001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1691953004/diff/30001/webrtc/video/full_stack.c... webrtc/video/full_stack.cc:46: void ForemanCifPlr5(std::string video_codec) { const std::string& here and elsewhere
https://codereview.webrtc.org/1691953004/diff/30001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1691953004/diff/30001/webrtc/video/full_stack.c... webrtc/video/full_stack.cc:46: void ForemanCifPlr5(std::string video_codec) { On 2016/02/12 10:47:56, pbos-webrtc wrote: > const std::string& here and elsewhere Done.
kjellander@webrtc.org changed reviewers: + phoglund@webrtc.org
This seems to add a lot of test time, which is not great until we've decided how to do with https://code.google.com/p/chromium/issues/detail?id=586238 Do you have an estimate on how much this adds? Especially on Debug Android.
Patchset #5 (id:90001) has been deleted
Patchset #7 (id:150001) has been deleted
Patchset #6 (id:130001) has been deleted
Patchset #5 (id:110001) has been deleted
On 2016/02/12 13:40:02, kjellander (webrtc) wrote: > This seems to add a lot of test time, which is not great until we've decided how > to do with https://code.google.com/p/chromium/issues/detail?id=586238 > > Do you have an estimate on how much this adds? Especially on Debug Android. Change so only two VP9 tests are added for now. PTAL.
lgtm
Seems more reasonable, thanks. We still have to figure out how to better run our perf tests... lgtm
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691953004/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691953004/170001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/785)
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691953004/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691953004/170001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
On 2016/02/12 16:40:50, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) > linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) > mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) > win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) There's still a queue but it's getting there. I'll check the CQ box again.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691953004/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691953004/170001
Message was sent while issue was closed.
Description was changed from ========== Add VP9 to full stack tests. BUG= ========== to ========== Add VP9 to full stack tests. BUG= ==========
Message was sent while issue was closed.
Committed patchset #5 (id:170001)
Message was sent while issue was closed.
Description was changed from ========== Add VP9 to full stack tests. BUG= ========== to ========== Add VP9 to full stack tests. BUG= Committed: https://crrev.com/88b0a2292a1f0331055cdfb193dacc43526a2367 Cr-Commit-Position: refs/heads/master@{#11608} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/88b0a2292a1f0331055cdfb193dacc43526a2367 Cr-Commit-Position: refs/heads/master@{#11608} |
