Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1691793002: Move the decoder thread into VideoReceiveStream. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move the decoder thread into VideoReceiveStream. BUG=webrtc:5494 R=stefan@webrtc.org Committed: https://crrev.com/ca8352541aac019f6e9f3c12dcbf5d7b81146f19 Cr-Commit-Position: refs/heads/master@{#11580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -62 lines) Patch
M webrtc/video/video_receive_stream.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 6 chunks +23 lines, -5 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/video/vie_channel.h View 4 chunks +0 lines, -9 lines 0 comments Download
M webrtc/video/vie_channel.cc View 6 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL, this removes ViEChannel from some calls and splits up send/receive functionality into corresponding streams.
4 years, 10 months ago (2016-02-11 14:35:10 UTC) #1
stefan-webrtc
lgtm
4 years, 10 months ago (2016-02-11 14:53:51 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as ca8352541aac019f6e9f3c12dcbf5d7b81146f19 (presubmit successful).
4 years, 10 months ago (2016-02-11 15:10:53 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 15:10:57 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ca8352541aac019f6e9f3c12dcbf5d7b81146f19
Cr-Commit-Position: refs/heads/master@{#11580}

Powered by Google App Engine
This is Rietveld 408576698