Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: webrtc/p2p/base/transportchannelimpl.h

Issue 1691673002: Remove GetTransport() from TransportChannelImpl (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Restore deleted P2PTransportChannel constructor (and mark deprecated) to not break Chromium Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_ 11 #ifndef WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
12 #define WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_ 12 #define WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
13 13
14 #include <string> 14 #include <string>
15 #include "webrtc/p2p/base/transport.h"
16 #include "webrtc/p2p/base/transportchannel.h" 15 #include "webrtc/p2p/base/transportchannel.h"
17 16
18 namespace buzz { class XmlElement; } 17 namespace buzz { class XmlElement; }
19 18
20 namespace cricket { 19 namespace cricket {
21 20
22 class Candidate; 21 class Candidate;
23 22
24 // TODO(pthatcher): Remove this once it's no longer used in 23 // TODO(pthatcher): Remove this once it's no longer used in
25 // remoting/protocol/libjingle_transport_factory.cc 24 // remoting/protocol/libjingle_transport_factory.cc
26 enum IceProtocolType { 25 enum IceProtocolType {
27 ICEPROTO_RFC5245 // Standard RFC 5245 version of ICE. 26 ICEPROTO_RFC5245 // Standard RFC 5245 version of ICE.
28 }; 27 };
29 28
30 // Base class for real implementations of TransportChannel. This includes some 29 // Base class for real implementations of TransportChannel. This includes some
31 // methods called only by Transport, which do not need to be exposed to the 30 // methods called only by Transport, which do not need to be exposed to the
32 // client. 31 // client.
33 class TransportChannelImpl : public TransportChannel { 32 class TransportChannelImpl : public TransportChannel {
34 public: 33 public:
35 explicit TransportChannelImpl(const std::string& transport_name, 34 explicit TransportChannelImpl(const std::string& transport_name,
36 int component) 35 int component)
37 : TransportChannel(transport_name, component) {} 36 : TransportChannel(transport_name, component) {}
38 37
39 // Returns the transport that created this channel.
40 virtual Transport* GetTransport() = 0;
41
42 // For ICE channels. 38 // For ICE channels.
43 virtual IceRole GetIceRole() const = 0; 39 virtual IceRole GetIceRole() const = 0;
44 virtual void SetIceRole(IceRole role) = 0; 40 virtual void SetIceRole(IceRole role) = 0;
45 virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0; 41 virtual void SetIceTiebreaker(uint64_t tiebreaker) = 0;
46 // TODO(pthatcher): Remove this once it's no longer called in 42 // TODO(pthatcher): Remove this once it's no longer called in
47 // remoting/protocol/libjingle_transport_factory.cc 43 // remoting/protocol/libjingle_transport_factory.cc
48 virtual void SetIceProtocolType(IceProtocolType type) {} 44 virtual void SetIceProtocolType(IceProtocolType type) {}
49 // SetIceCredentials only need to be implemented by the ICE 45 // SetIceCredentials only need to be implemented by the ICE
50 // transport channels. Non-ICE transport channels can just ignore. 46 // transport channels. Non-ICE transport channels can just ignore.
51 // The ufrag and pwd should be set before the Connect() is called. 47 // The ufrag and pwd should be set before the Connect() is called.
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 // channel decreases. 99 // channel decreases.
104 sigslot::signal1<TransportChannelImpl*> SignalConnectionRemoved; 100 sigslot::signal1<TransportChannelImpl*> SignalConnectionRemoved;
105 101
106 private: 102 private:
107 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannelImpl); 103 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannelImpl);
108 }; 104 };
109 105
110 } // namespace cricket 106 } // namespace cricket
111 107
112 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_ 108 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
OLDNEW
« no previous file with comments | « webrtc/p2p/base/p2ptransportchannel_unittest.cc ('k') | webrtc/p2p/quic/quicsession_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698