Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1690893002: Revert of Make cricket::VideoCapturer implement VideoSourceInterface (Closed)

Created:
4 years, 10 months ago by perkj_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make cricket::VideoCapturer implement VideoSourceInterface (patchset #14 id:300001 of https://codereview.webrtc.org/1655793003/ ) Reason for revert: Needs to revert again unfortunately. There are multiple implementations in Chrome of cricket::VideoCapturer. One is ./../remoting/protocol/webrtc_video_capturer_adapter.cc... https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/9581/steps/compile/logs/stdio Fun times - I will have to modify this cl after trying it manually out in Chrome. Original issue's description: > This cl introduce a VideoSourceInterface and let cricket::VideoCapturer implement it. > Further more, it adds a VideoBroadcaster than is used for delivering frames to multiple sinks. > > BUG=webrtc:5426 > R=nisse@webrtc.org, pthatcher@webrtc.org > > Committed: https://crrev.com/4d19c5b010473615fa181afa84c6f4b3104e3171 > Cr-Commit-Position: refs/heads/master@{#11567} TBR=pthatcher@google.com,nisse@webrtc.org,pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5426 Committed: https://crrev.com/162c3393bee23f81984041864817f0f8f5b31d16 Cr-Commit-Position: refs/heads/master@{#11568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -362 lines) Patch
M talk/session/media/channelmanager.h View 1 chunk +1 line, -0 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/androidvideocapturer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/api/remotevideocapturer_unittest.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M webrtc/media/base/capturemanager.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/media/base/capturemanager.cc View 8 chunks +46 lines, -12 lines 0 comments Download
A webrtc/media/base/capturerenderadapter.h View 1 chunk +58 lines, -0 lines 0 comments Download
M webrtc/media/base/capturerenderadapter.cc View 1 chunk +73 lines, -1 line 0 comments Download
M webrtc/media/base/fakevideorenderer.h View 3 chunks +0 lines, -6 lines 0 comments Download
D webrtc/media/base/videobroadcaster.h View 1 chunk +0 lines, -60 lines 0 comments Download
D webrtc/media/base/videobroadcaster.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 8 chunks +13 lines, -16 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 4 chunks +13 lines, -21 lines 0 comments Download
M webrtc/media/base/videocapturer_unittest.cc View 13 chunks +53 lines, -66 lines 0 comments Download
M webrtc/media/base/videoengine_unittest.h View 1 chunk +15 lines, -0 lines 0 comments Download
M webrtc/media/base/videosinkinterface.h View 1 chunk +2 lines, -1 line 0 comments Download
D webrtc/media/base/videosourceinterface.h View 1 chunk +0 lines, -46 lines 0 comments Download
M webrtc/media/media.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/webrtc/webrtcvideocapturer.h View 3 chunks +10 lines, -7 lines 0 comments Download
M webrtc/media/webrtc/webrtcvideocapturer.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M webrtc/media/webrtc/webrtcvideoengine2.h View 5 chunks +3 lines, -7 lines 0 comments Download
M webrtc/media/webrtc/webrtcvideoengine2.cc View 11 chunks +31 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
perkj_webrtc
Created Revert of Make cricket::VideoCapturer implement VideoSourceInterface
4 years, 10 months ago (2016-02-11 10:56:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690893002/1
4 years, 10 months ago (2016-02-11 10:56:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690893002/1
4 years, 10 months ago (2016-02-11 10:56:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 10:56:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 10:56:40 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 10:56:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/162c3393bee23f81984041864817f0f8f5b31d16
Cr-Commit-Position: refs/heads/master@{#11568}

Powered by Google App Engine
This is Rietveld 408576698