Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1690193003: Remove Reset from conditionally-compiled decoders. (Closed)

Created:
4 years, 10 months ago by pbos-webrtc
Modified:
4 years, 10 months ago
Reviewers:
hbos, tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove Reset from conditionally-compiled decoders. Reset is no longer called but removal of them was missed in a previous commit. BUG=webrtc:5475 TBR=hbos@webrtc.org,tkchin@webrtc.org Committed: https://crrev.com/b72dada927047c9390a0f861e540da44288ebca9 Cr-Commit-Position: refs/heads/master@{#11603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
Committed patchset #1 (id:1) manually as b72dada927047c9390a0f861e540da44288ebca9 (presubmit successful).
4 years, 10 months ago (2016-02-12 14:57:09 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b72dada927047c9390a0f861e540da44288ebca9 Cr-Commit-Position: refs/heads/master@{#11603}
4 years, 10 months ago (2016-02-12 14:57:12 UTC) #4
tkchin_webrtc
On 2016/02/12 14:57:12, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 10 months ago (2016-02-12 23:24:28 UTC) #5
hbos
4 years, 10 months ago (2016-02-15 08:41:49 UTC) #6
Message was sent while issue was closed. 
On 2016/02/12 23:24:28, tkchin_webrtc wrote:
> On 2016/02/12 14:57:12, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/b72dada927047c9390a0f861e540da44288ebca9
> > Cr-Commit-Position: refs/heads/master@{#11603}
> 
> lgtm thanks

lgtm

Powered by Google App Engine
This is Rietveld 408576698