Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1690073002: Revert of Android: Remove VideoCapturer (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android: Remove VideoCapturer (patchset #2 id:20001 of https://codereview.webrtc.org/1684403002/ ) Reason for revert: Breaks downstream compilation. Please reland in a non-breaking fashion. Original issue's description: > Android: Remove VideoCapturer > > This CL makes PeerConnectionFactory.createVideoSource() and nativeCreateVideoSource work directly with VideoCapturerAndroid instead of going via VideoCapturer. The native part is now created in nativeCreateVideoSource() instead of doing it immediately in VideoCapturerAndroid.create(). > > BUG=webrtc:5519 > R=perkj@webrtc.org > > Committed: https://crrev.com/09eab315fddc3432c19d8f662f4b9360f2a58010 > Cr-Commit-Position: refs/heads/master@{#11582} TBR=perkj@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5519 Committed: https://crrev.com/af71655b682d2c91a4843bfd911d11e5f68cfe86 Cr-Commit-Position: refs/heads/master@{#11586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -37 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 9 chunks +22 lines, -13 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 5 chunks +19 lines, -5 lines 0 comments Download
M webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java View 2 chunks +3 lines, -5 lines 0 comments Download
A webrtc/api/java/src/org/webrtc/VideoCapturer.java View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
Created Revert of Android: Remove VideoCapturer
4 years, 10 months ago (2016-02-11 20:21:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690073002/1
4 years, 10 months ago (2016-02-11 20:21:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 20:21:49 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 20:21:56 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af71655b682d2c91a4843bfd911d11e5f68cfe86
Cr-Commit-Position: refs/heads/master@{#11586}

Powered by Google App Engine
This is Rietveld 408576698